8000 chore: bump minimum version of google-cloud-access-context-manager by parthea · Pull Request #2582 · googleapis/gapic-generator-python · GitHub
[go: up one dir, main page]
Skip to content

chore: bump minimum version of google-cloud-access-context-manager#2582

Merged
parthea merged 2 commits intomainfrom
parthea-patch-5
Mar 12, 2026
Merged

chore: bump minimum version of google-cloud-access-context-manager#2582
parthea merged 2 commits intomainfrom
parthea-patch-5

Conversation

@parthea
Copy link
Contributor
@parthea parthea commented Mar 12, 2026 •
edited
Loading

PR #2502 updated the minimum version of protobuf to 4.25.8

gapic-generator-python/gapic/templates/setup.py.j2

Line 45 in bba0231

"protobuf >= 4.25.8, < 8.0.0",

pip install protobuf==4.25.8 google-cloud-access-context-manager==0.1.2 google-api-core==2.21.0 fails with the following error

Collecting protobuf==4.25.8
  Using cached protobuf-4.25.8-cp37-abi3-manylinux2014_x86_64.whl.metadata (541 bytes)
ERROR: Cannot install google-api-core==2.21.0 and google-cloud-access-context-manager==0.1.2 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested google-api-core==2.21.0
    google-cloud-access-context-manager 0.1.2 depends on google-api-core<2.0.0dev and >=1.14.0

Additionally, some packages in these conflicts have no matching distributions available for your environment:
    google-api-core

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict

google-cloud-access-context-manager==0.1.8 is the first version to allow google-api-core 2.x

https://github.com/googleapis/python-access-context-manager/releases/tag/v0.1.8

@parthea parthea requested a review from a team as a code owner March 12, 2026 10:16
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 12, 2026
@gemini-code-assist
Copy link
Contributor
gemini-code-assist bot commented Mar 12, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical dependency conflict that emerged after a protobuf version update. By adjusting the minimum version requirement for google-cloud-access-context-manager, it ensures that generated setup.py files will correctly resolve dependencies, preventing installation failures and maintaining compatibility across the project's ecosystem.

Highlights

  • Dependency Resolution: Resolved a dependency conflict caused by a recent protobuf version bump (to 4.25.8) which led to incompatibility between google-api-core and google-cloud-access-context-manager.
  • Version Bump: Increased the minimum required version of google-cloud-access-context-manager from 0.1.2 to 0.1.8 to ensure compatibility with google-api-core 2.x.
Changelog
  • gapic/templates/_pypi_packages.j2
    • Updated the lower_bound for google-cloud-access-context-manager from 0.1.2 to 0.1.8.
Activity
  • No specific review comments or activities have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum version of the google-cloud-access-context-manager package from 0.1.2 to 0.1.8 in the _pypi_packages.j2 template. This change correctly addresses a dependency conflict with google-api-core version 2.x, which was introduced by a recent update to the minimum required protobuf version. The change is well-justified and appears to be correct.

@parthea parthea mentioned this pull request Mar 12, 2026
Open
chalmerlowe
chalmerlowe approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor
@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea enabled auto-merge (squash) March 12, 2026 11:08
chalmerlowe
chalmerlowe approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor
@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea merged commit d1fa8a7 into main Mar 12, 2026
113 checks passed
@parthea parthea deleted the parthea-patch-5 branch March 12, 2026 11:35
This was referenced Mar 12, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tswast tswast

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @chalmerlowe @tswast
0