8000 tests: downgrade mypy to 1.16.0 by parthea · Pull Request #2580 · googleapis/gapic-generator-python · GitHub
[go: up one dir, main page]
Skip to content

tests: downgrade mypy to 1.16.0#2580

Merged
parthea merged 1 commit intomainfrom
downgrade-mypy
Mar 11, 2026
Merged

tests: downgrade mypy to 1.16.0#2580
parthea merged 1 commit intomainfrom
downgrade-mypy

Conversation

@parthea
Copy link
Contributor
@parthea parthea commented Mar 11, 2026

Partial revert of #2530 due to downstream mypy failures: #2579

@parthea parthea requested a review from a team as a code owner March 11, 2026 14:03
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 11, 2026
@gemini-code-assist
Copy link
Contributor
gemini-code-assist bot commented Mar 11, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical mypy type-checking failures by temporarily downgrading the mypy dependency to version 1.16.0. This ensures the stability of the type-checking tests while a more permanent solution for compatibility with newer mypy versions is investigated. The change is a targeted revert to mitigate immediate build issues.

Highlights

  • Mypy Version Downgrade: The mypy dependency has been explicitly pinned to version 1.16.0 (i.e., mypy<1.16.0) in various noxfile.py configurations to address recent type-checking failures.
  • Partial Revert: This change partially reverts a previous update to mypy (PR fix: improve type checking #2530) to resolve downstream issues, as documented in issue Latest mypy checks fail for several generated packages #2579.
  • Future Mypy Update: A TODO comment has been added to the affected noxfile.py files, indicating that the latest version of mypy should be used once the underlying issues are resolved.
Changelog
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 11, 2026
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades mypy to <1.16.0 to address downstream failures, which is a reasonable temporary fix. The change is correctly 8000 applied to the noxfile.py.j2 template. However, the corresponding golden files under tests/integration/goldens/ have been manually patched instead of being regenerated from the updated template. My review includes a comment recommending that these files be regenerated to ensure consistency and adhere to the project's contribution guidelines.

@parthea parthea merged commit 4f0c8ee into main Mar 11, 2026
113 checks passed
@parthea parthea deleted the downgrade-mypy branch March 11, 2026 16:52
@parthea parthea mentioned this pull request Mar 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ohmayr ohmayr ohmayr approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowe chalmerlowe

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @ohmayr @chalmerlowe
0