-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since 8.1.4 YAML.parseAllDocuments is not allowed from zx #870
Comments
Before this release YAML.parseAllDocuments was possible, after release 8.1.4 its no longer there. It should be another way to use it since now, or is it an accidental removal? |
I'm afraid, the mentioned extra API was previously accidentally added. zx is aimed to provide just a basic |
Do not agree with your statement: |
I agree... even If it has to be removed, should not be done in a minor update. |
The problem is that we haven't covered this part of the API with tests. That's why it failed so badly. We will definitely invest time to increase vendor chunk test coverage.
This is how it happened: |
I see your point, but initial description of zx goods does not describe that there is a limited set of yaml package, it describes that the whole yaml package available. So if it is really needed to remove additional methods it is like removing the whole package, which breaks backward compatibility. I do not see any point in breaking compatibility within the same major version and do not see any point in still having yaml package and dependencies and artificially removing its methods. |
Signed-off-by: billimek <jeff@billimek.com>
So, there is no plan to revert the mentioned change, correct? |
Can we create a small stub for this methods? @antongolub not copy original defs, but createca simple method which returns any? |
I don't mind, but let's also mark it as deprecated. |
Expected Behavior
Actual Behavior
Steps to Reproduce
Specifications
The text was updated successfully, but these errors were encountered: