This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
More bugfixes in build scripts #4695
Merged
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `install.sh` had no `set -eu` and was calling `conan` directly. 2. `bootstrap-orbit.ps1` had an inverted conan version check. 3. `build.sh` and `build.ps` now build `default_release` by default. This will help reducing build times for first timers because there are packages for the release config in Conan Center, but not for `RelWithDebInfo`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install.shhad noset -euand was callingconandirectly.bootstrap-orbit.ps1had an inverted conan version check.build.shandbuild.psnow builddefault_releaseby default. This will help reducing build times for first timers because there are packages for the release config in Conan Center, but not forRelWithDebInfo.