8000 Add some new style properties to the Style class by richard-to · Pull Request #300 · google/mesop · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some new style properties to the Style class #300

Merged
merged 1 commit into from
May 24, 2024
Merged

Add some new style properties to the Style class #300

merged 1 commit into from
May 24, 2024

Conversation

richard-to
Copy link
Collaborator

New properties

  • visibility
  • opacity
  • top / left / right / bottom
  • Add remaining grid properties:
    • grid_auto_columns
    • grid_auto_flow
    • grid_auto_rows
    • grid_column
    • grid_row
    • Exception: left out grid_template property

Also some minor style property fixes

@richard-to richard-to force-pushed the add-more-styles branch 3 times, most recently from 3abd5fd to 4c12c3e Compare May 24, 2024 04:07
@richard-to
Add some new style properties to the Style class
b6d460e 
New properties

 - visibility
 - opacity
 - top / left / right / bottom
 - Add remaining grid properties:
   - grid_auto_columns
   - grid_auto_flow
   - grid_auto_rows
   - grid_column
   - grid_row
   - Exception: left out grid_template property

Also update animations using opacity and position properties

Also some minor style property fixes

- Allow string values for:
  - grid_column_start
  - grid_column_end
  - grid_row_start
  - grid_row_end
- Fix potential bug with direct str conversions
  - If the value is not set, setting str(property) would yield 'None'
  - That seems undesirable, so add _int_str and _float_str wrappers
@richard-to richard-to merged commit 536351c into google:main May 24, 2024
3 checks passed
@richard-to richard-to deleted the add-more-styles branch June 6, 2024 14:22
wwwillchen pushed a commit to wwwillchen/mesop that referenced this pull request Jun 14, 2024
@richard-to @wwwillchen
Add some new style properties to the Style class (google#300)
762c877 
New properties

 - visibility
 - opacity
 - top / left / right / bottom
 - Add remaining grid properties:
   - grid_auto_columns
   - grid_auto_flow
   - grid_auto_rows
   - grid_column
   - grid_row
   - Exception: left out grid_template property

Also update animations using opacity and position properties

Also some minor style property fixes

- Allow string values for:
  - grid_column_start
  - grid_column_end
  - grid_row_start
  - grid_row_end
- Fix potential bug with direct str conversions
  - If the value is not set, setting str(property) would yield 'None'
  - That seems undesirable, so add _int_str and _float_str wrappers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwillchen wwwillchen wwwillchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richard-to @wwwillchen
0