ollama: send keep_alive at top level #267
Conversation
|
Your branch is 1 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
|
Your branch is 3 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
|
Your branch is 4 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
|
Your branch is 8 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
|
Your branch is 10 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
2 similar comments
|
Your branch is 10 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
|
Your branch is 10 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
|
Hey, just checking on this. Is there any issues with the code? |
fixes #256 This PR aligns the Ollama provider with the Ollama API by sending keep_alive at the payload’s top level while keeping options.keep_alive for backward compatibility.
Changes
Provider: compute keep_alive once, set payload['keep_alive'] and options['keep_alive'].
Tests: in tests/inference_test.py:
test_ollama_extra_kwargs_passed_to_api: assert payload['keep_alive'] == 600.
test_ollama_defaults_when_unspecified: assert payload['keep_alive'] == 300.
Compatibility
Backward-compatible: options.keep_alive is still present. No breaking API changes.