Fix MutexLock compilation in main_portable.cc for IDA Pro 9.1 on Windows#87
Open
adeliktas wants to merge 1 commit intogoogle:mainfrom
Open
Fix MutexLock compilation in main_portable.cc for IDA Pro 9.1 on Windows#87adeliktas wants to merge 1 commit intogoogle:mainfrom
adeliktas wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When building BinDiff from source on Windows for IDA Pro 9.1, compilation fails in main_portable.cc at line 216 with error C2664: Cannot convert 'absl::Mutex' to 'absl::Mutex*'.
The line is:
absl::MutexLock lock(g_queue_mutex);This is because the absl::MutexLock constructor requires a pointer to Mutex.
Fix: Change to
absl::MutexLock lock(&g_queue_mutex);Tested on: Windows 10, Visual Studio 2019, CMake 4.2.3.
This fixes the build successfully. Solves for #84