feat: Add BM25 retriever for in-memory memory service - issue #786 #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa5f305 to
8f92e31
Compare
8f92e31 to
ea8406e
Compare
7b8e8f1 to
e799bcb
Compare
feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Format and remove lock file Fix dpes feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Format and remove lock file Fix dpes feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Format and remove lock file Fix dpes feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Remove uv lock feat: Add BM25 as an option for inmemory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 feat: Add BM25 in-memory memory service - issue google#786 Fix dpes
e799bcb to
6ee900b
Compare
8000
|
Hi @hangfei Just wanted to gently check in on the above PR submitted a few weeks ago. When you get a chance, could you please take a look? Thankyou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #786
This PR introduces a BM25-based retriever - the
InMemoryBM25RetrievalMemoryServiceusing therank_bm25library. This gives users another option in for in-memory memory in addition to the keyword based memory. This enhances search relevance by leveraging a proven term-weighting algorithm.Key Changes
rank_bm25to provide BM25 search capabilities.max_resultsparameter (defaults to 3 when BM25 is used)Testing Plan
uv build)pyink.*)