8000 fix: Support for parallel tool calling using SSE with LiteLLM by lucasnobre212 · Pull Request #759 · google/adk-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Support for parallel tool calling using SSE with LiteLLM #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix: Support for parallel tool calling using SSE with LiteLLM #759

wants to merge 3 commits into from

Conversation

lucasnobre212
Copy link
Contributor
@lucasnobre212 lucasnobre212 commented May 16, 2025 •
edited
Loading

Fixes #484

This PR adds support for parallel tool calls by creating an dict to keep track of the index and correctly appending the strings.

@lucasnobre212 lucasnobre212 changed the title Add support for parallel tool calling using SSE with LiteLLM feat: Add support for parallel tool calling using SSE with LiteLLM May 16, 2025
@lucasnobre212 lucasnobre212 changed the title feat: Add support for parallel tool calling using SSE with LiteLLM fix: Support for parallel tool calling using SSE with LiteLLM May 16, 2025
@lucasnobre212 lucasnobre212 marked this pull request as ready for review May 16, 2025 10:33
@lucasnobre212
Copy link
Contributor Author

I have tested using OpenAI and it works well.

@lucasnobre212 lucasnobre212 marked this pull request as draft May 16, 2025 10:37
@lucasnobre212 lucasnobre212 marked this pull request as ready for review May 16, 2025 10:38
selcukgun
selcukgun approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator
@selcukgun selcukgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

@selcukgun selcukgun added the ready to pull for importing back to Google label May 29, 2025
copybara-service bot pushed a commit that referenced this pull request May 29, 2025
@lucasnobre212 @copybara-github
Copybara import of the project:
05f4834 
--
cef3ca1 by Lucas Nobre <lucaas.sn@gmail.com>:

feat: Add index tracking to handle parallel tool call using litellm
COPYBARA_INTEGRATE_REVIEW=#759 from lucasnobre212:fix/issue_484 65e2293
PiperOrigin-RevId: 764902433
@selcukgun
Copy link
Collaborator

merged by copybara: 05f4834

@selcukgun selcukgun closed this May 29, 2025
@selcukgun selcukgun mentioned this pull request May 29, 2025
Closed
whhlct pushed a commit to whhlct/adk-python that referenced this pull request Jun 6, 2025
@lucasnobre212 @whhlct
Copybara import of the project:
7acedfe 
--
cef3ca1 by Lucas Nobre <lucaas.sn@gmail.com>:

feat: Add index tracking to handle parallel tool call using litellm
COPYBARA_INTEGRATE_REVIEW=google#759 from lucasnobre212:fix/issue_484 65e2293
PiperOrigin-RevId: 764902433
@akshatshah-21 akshatshah-21 mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selcukgun selcukgun selcukgun approved these changes

Assignees
No one assigned
Labels
ready to pull for importing back to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LiteLlm generate_content_async doesn't handle multiple tool calls in the same model response in SSE mode
2 participants
@lucasnobre212 @selcukgun
0