8000 fix: Update load_memory_tool.py by shu8hamrajput · Pull Request #389 · google/adk-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Update load_memory_tool.py #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: Update load_memory_tool.py #389

wants to merge 2 commits into from

Conversation

shu8hamrajput
Copy link
Contributor

make query args required.

@google-cla Google CLA
Copy link
google-cla bot commented Apr 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shu8hamrajput shu8hamrajput mentioned this pull request Apr 25, 2025
Closed
@gsarthakdev
Copy link
Contributor

@shu8hamrajput Please sign a Contributor License Agreement (CLA) here to allow the repository maintainers to review the code.

@shu8hamrajput
Copy link
Contributor Author
shu8hamrajput commented Apr 25, 2025 •
edited
Loading

I've already signed CLA. IDK why it is still failing.
PS: this is my first contribution

UPDATE: figured it out after some efforts.

@shu8hamrajput shu8hamrajput changed the title Update load_memory_tool.py Update load_memory_tool.py and make query mandatory Apr 25, 2025
@shu8hamrajput
fix: Update load_memory_tool.py
19b6701 
make `query` args required.
@shu8hamrajput shu8hamrajput force-pushed the fix/make-query-required-arg branch from 20be3dd to 19b6701 Compare April 25, 2025 19:18
@seanzhou1023 seanzhou1023 changed the title Update load_memory_tool.py and make query mandatory fix: Update load_memory_tool.py May 28, 2025
@seanzhou1023 seanzhou1023 added the ready to pull for importing back to Google label May 28, 2025
copybara-service bot pushed a commit that referenced this pull request May 28, 2025
@shu8hamrajput @copybara-github
Copybara import of the project:
3611e9f 
--
19b6701 by shubham rajput <42935066+shu8hamrajput@users.noreply.github.com>:

fix: Update load_memory_tool.py

make `query` args required.

COPYBARA_INTEGRATE_REVIEW=#389 from shu8hamrajput:fix/make-query-required-arg 92eb647
PiperOrigin-RevId: 764303198
raflFaisal pushed a commit to raflFaisal/adk-python that referenced this pull request May 28, 2025
@shu8hamrajput @raflFaisal
Copybara import of the project:
312ea60 
--
19b6701 by shubham rajput <42935066+shu8hamrajput@users.noreply.github.com>:

fix: Update load_memory_tool.py

make `query` args required.

COPYBARA_INTEGRATE_REVIEW=google#389 from shu8hamrajput:fix/make-query-required-arg 92eb647
PiperOrigin-RevId: 764303198
@hangfei
Copy link
Collaborator
hangfei commented May 30, 2025

merged in 3611e9f. thanks!

@hangfei hangfei closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanzhou1023 seanzhou1023 seanzhou1023 approved these changes

Assignees
No one assigned
Labels
ready to pull for importing back to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shu8hamrajput @gsarthakdev @hangfei @seanzhou1023
0