fix: Fix error when query job destination is None #3127
Conversation
Summary of ChangesHello @na0fu3y, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request fixes an error in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| destination_dataset_id = None | ||
| if dry_run_query_job.destination: | ||
| destination_dataset_id = dry_run_query_job.destination.dataset_id | ||
|
|
||
| if ( | ||
| dry_run_query_job.statement_type != "SELECT" | ||
| and dry_run_query_job.destination.dataset_id != bq_session_dataset_id | ||
| and destination_dataset_id != bq_session_dataset_id | ||
| and destination_dataset_id is not None | ||
| ): |
There was a problem hiding this comment.
While the current implementation correctly fixes the bug, it can be simplified for better readability and conciseness. By leveraging Python's short-circuiting behavior with and, you can perform the check for dry_run_query_job.destination and access its dataset_id within the same conditional expression. This avoids creating a temporary variable and makes the logic more direct.
if (
dry_run_query_job.statement_type != "SELECT"
and dry_run_query_job.destination
and dry_run_query_job.destination.dataset_id != bq_session_dataset_id
):
What this PR does
This PR fixes a bug in the
execute_sql functionwithinbigquery/query_tool.py. The bug caused an error when executing queries that do not return a result set, such as aCREATE TEMP FUNCTIONstatement.The problem
Within
execute_sql,when a user executed a query that doesn't produce a result set, like the following:The corresponding BigQuery job object would have its
destinationproperty set toNone. This caused an error because the code was written with the expectation of a valid destination table.The solution
The fix modifies
execute_sqlto check if thequery_job.destinationis None. If it is, the function correctly identifies the query as a statement that doesn't require a destination and allows it to complete successfully.This ensures that
execute_sqlcan robustly handle these types of queries.