8000 fix: agent generate config error by simonwei97 · Pull Request #1450 · google/adk-python · GitHub
[go: up one dir, main page]
Skip to content

fix: agent generate config error #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

fix: agent generate config error #1450

merged 2 commits into from
Jun 17, 2025
+82 −11

Conversation

simonwei97
Copy link
Contributor

Fixes: #1302

Previous PR(#1305) has been reverted by commit 1cfc555. So I submit new PR for bug fix.

@genquan9

genquan9
genquan9 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator
@genquan9 genquan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@genquan9 genquan9 mentioned this pull request Jun 17, 2025
Closed
@genquan9 genquan9 merged commit 694b712 into google:main Jun 17, 2025
9 checks passed
@genquan9 genquan9 added the ready to pull for importing back to Google label Jun 18, 2025
hangfei added a commit that referenced this pull request Jun 18, 2025
@hangfei
Revert "fix: agent generate config error (#1450)"
34eeb48 
This reverts commit 694b712.
@hangfei hangfei mentioned this pull request Jun 18, 2025
Closed
@genquan9
Copy link
Collaborator

There were some issues in the process when merge the PR. Could you send a new PR? Sorry for the inconveniences, and thanks for your help!

@simonwei97 simonwei97 deleted the agent-generate-config-err branch June 19, 2025 01:29
@simonwei97
Copy link
Contributor Author

There were some issues in the process when merge the PR. Could you send a new PR? Sorry for the inconveniences, and thanks for your help!

ok.

@simonwei97 simonwei97 mentioned this pull request Jun 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genquan9 genquan9 genquan9 approved these changes

Assignees
No one assigned
Labels
ready to pull for importing back to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLM Generation Config(generate_content_config) does not work.
2 participants
@simonwei97 @genquan9
0