8000 refactor: use custom NotFoundError when session is not found, instead of ValueError by Tobias-Freire · Pull Request #1384 · google/adk-python · GitHub
[go: up one dir, main page]
Skip to content

refactor: use custom NotFoundError when session is not found, instead of ValueError #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor: use custom NotFoundError when session is not found, instead of ValueError #1384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32704ea
refactor: use custom NotFoundError when session is not found, instead…
Tobias-Freire Jun 13, 2025
c936b76
Merge branch 'main' into refactor/use-NotFoundError-when-session_not_…
Jacksunwei Jun 14, 2025
0df4559
fix: sort imports
Tobias-Freire Jun 15, 2025
177536f
Merge branch 'main' into refactor/use-NotFoundError-when-session_not_…
hangfei Jun 15, 2025
9507642
Merge branch 'main' into refactor/use-NotFoundError-when-session_not_…
Tobias-Freire Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: sort imports
  • Loading branch information
@Tobias-Freire
Tobias-Freire committed Jun 15, 2025
commit 0df4559d4c3d2cc011edf8ea3708ef0ad5b165d4
2 changes: 1 addition & 1 deletion src/google/adk/runners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
from .artifacts.base_artifact_service import BaseArtifactService
from .artifacts.in_memory_artifact_service import InMemoryArtifactService
from .code_executors.built_in_code_executor import BuiltInCodeExecutor
from .errors.not_found_error import NotFoundError
from .events.event import Event
from .memory.base_memory_service import BaseMemoryService
from .memory.in_memory_memory_service import InMemoryMemoryService
Expand All @@ -44,7 +45,6 @@
from .sessions.session import Session
from .telemetry import tracer
from .tools.base_toolset import BaseToolset
from .errors.not_found_error import NotFoundError

logger = logging.getLogger('google_adk.' + __name__)

Expand Down
2 changes: 1 addition & 1 deletion tests/unittests/sessions/test_vertex_ai_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
from unittest import mock

from dateutil.parser import isoparse
from google.adk.errors.not_found_error import NotFoundError
from google.adk.events import Event
from google.adk.events import EventActions
from google.adk.sessions import Session
from google.adk.sessions import VertexAiSessionService
from google.adk.errors.not_found_error import NotFoundError
from google.genai import types
import pytest

Expand Down
0