8000 fix: Make FunctionTool slightly more null safe, and use Text Blocks by vorburger · Pull Request #485 · google/adk-java · GitHub
[go: up one dir, main page]
Skip to content

fix: Make FunctionTool slightly more null safe, and use Text Blocks #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Make FunctionTool slightly more null safe, and use Text Blocks #485

wants to merge 1 commit into from
+15 −11

Conversation

vorburger
Copy link
Member

This is in anticipation of doing more work in this class in the context of #473; it just makes it easier to working on and raising more changes, and these automagic changes propose by VSC actually do make sense, instead of having to "fight your IDE" to undo this when working on this class.

@vorburger vorburger requested a review from Poggecci October 7, 2025 19:02
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces minor but significant refinements to the FunctionTool class. The changes focus on improving the robustness of the code by preventing potential null pointer exceptions in string comparisons and boosting readability through the adoption of Java Text Blocks for multi-line strings. These updates are foundational, aiming to streamline future development and maintenance within this class.

Highlights

  • Null Safety Enhancement: Improved null safety within the FunctionTool class by reordering the @Nullable annotation for the instance field and adopting a safer string comparison idiom ("string".equals(variable)) for parameter names like toolContext and inputStream.
  • Code Readability: Enhanced the readability of multi-line log messages by converting them to Java Text Blocks, making the code cleaner and easier to maintain.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several small but useful changes to the FunctionTool class. The use of text blocks for multi-line strings improves readability, and the changes to use type annotations for @Nullable and equals() on string literals for null-safety are good practices. I've included a couple of minor suggestions to further improve the code style and consistency.

@vorburger vorburger marked this pull request as draft October 7, 2025 19:23
@vorburger
fix: Make FunctionTool slightly more null safe, and use Text Blocks
a2295a3 
This is in anticipation of doing more work in this class
in the context of google#473;
it just makes it easier to working on and raising more changes,
and these automagic changes propose by VSC actually do make sense,
instead of having to "fight your IDE" to undo this when working on this class.
@vorburger vorburger force-pushed the issue-473_FunctionTool-clean branch from 9c1f7ea to a2295a3 Compare October 7, 2025 19:47
@vorburger vorburger marked this pull request as ready for review October 7, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poggecci Poggecci Awaiting requested review from Poggecci

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vorburger
0