8000 docs: explain limitation of new-from-rev and new-from-patch by ldez · Pull Request #4377 · golangci/golangci-lint · GitHub
[go: up one dir, main page]
Skip to content

docs: explain limitation of new-from-rev and new-from-patch #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2024
Merged

docs: explain limitation of new-from-rev and new-from-patch #4377

merged 3 commits into from
Feb 12, 2024

Conversation

ldez
Copy link
Member
@ldez ldez commented Feb 12, 2024

Closes #4376

@ldez ldez added enhancement New feature or improvement area: docs labels Feb 12, 2024
@ldez ldez requested a review from bombsimon February 12, 2024 15:37
@ldez ldez mentioned this pull request Feb 12, 2024
Closed
5 tasks
facchettos
facchettos reviewed Feb 12, 2024
View reviewed changes
bombsimon
bombsimon approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member
@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 2 commits February 12, 2024 18:25
@ldez @bombsimon
Update docs/src/docs/usage/faq.mdx
a593172 
Co-authored-by: Simon Sawert <simon@sawert.se>
@ldez @facchettos
Update docs/src/docs/usage/faq.mdx
8567715 
Co-authored-by: Jeremy Facchetti <facchettos@gmail.com>
@ldez ldez merged commit 403437e into golangci:master Feb 12, 2024
@ldez ldez deleted the fix/doc-new-from-rev branch February 12, 2024 17:37
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bombsimon bombsimon bombsimon approved these changes

+1 more reviewer

@facchettos facchettos 5D70 facchettos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: docs enhancement New feature or improvement

Projects

None yet

Milestone

v1.56

Development

Successfully merging this pull request may close these issues.

--new-from-rev main doesn't work

3 participants

@ldez @bombsimon @facchettos
0