8000 gofumpt: Add extra-rules option + update linter by Nivl · Pull Request #1228 · golangci/golangci-lint · GitHub
[go: up one dir, main page]
Skip to content

gofumpt: Add extra-rules option + update linter #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2020
Merged

gofumpt: Add extra-rules option + update linter #1228

merged 2 commits into from
Jul 12, 2020

Conversation

Nivl
Copy link
Contributor
@Nivl Nivl commented Jul 10, 2020

This PR does the following:

@boring-cyborg
Copy link
boring-cyborg bot commented Jul 10, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link
CLAassistant commented Jul 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@WillAbides
Copy link

Thanks for this PR. I was just about to start on the same thing and came by here to double check it isn't already in progress. If I had been 10 minutes earlier, I would have duplicated your work.

@SVilgelm SVilgelm mentioned this pull request Jul 12, 2020
Closed
@SVilgelm SVilgelm added enhancement New feature or improvement linter: update version Update version of linter labels Jul 12, 2020
@SVilgelm
Copy link
Member

@Nivl Hi, could you please resolve conflicts with go.sum?

@SVilgelm SVilgelm mentioned this pull request Jul 12, 2020
Closed
SVilgelm
SVilgelm approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member
@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@SVilgelm SVilgelm merged commit ee86e0e into golangci:master Jul 12, 2020
@golangci-automator
Copy link

Hey, @Nivl — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@SVilgelm SVilgelm linked an issue Jul 13, 2020 that may be closed by this pull request
Add gofumpt #490
Closed
@SVilgelm SVilgelm mentioned this pull request Jul 17, 2020
Closed
@ldez ldez added this to the v1.29 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVilgelm SVilgelm SVilgelm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement linter: update version Update version of linter
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

Add gofumpt
5 participants
@Nivl @CLAassistant @WillAbides @SVilgelm @ldez
0