8000 net/http2: don't re-use connections that are experiencing errors by btasker · Pull Request #171 · golang/net · GitHub
[go: up one dir, main page]
Skip to content

net/http2: don't re-use connections that are experiencing errors #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+234 −128
Open

net/http2: don't re-use connections that are experiencing errors #171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebc51a0
net/http2: don't reuse connections that are experiencing errors
btasker Apr 27, 2023
ef8ed4e
net/http2: increase verbosity of `TestTransportRetryAfterGOAWAY` to a…
btasker Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net/http2: increase verbosity of TestTransportRetryAfterGOAWAY to a… 
…id debugging
  • Loading branch information
@btasker
btasker committed Apr 28, 2023
commit ef8ed4e97772f5730e72f346e13ba5a1151927e1
5 changes: 3 additions & 2 deletions http2/transport_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3821,7 +3821,8 @@ func TestTransportRetryAfterGOAWAY(t *testing.T) {
t.Errorf("server1 failed reading HEADERS: %v", err)
return
}
t.Logf("server1 got %v", hf)
t.Logf("server1 got %v from %v", hf, ct.sc.RemoteAddr())

if err := ct.fr.WriteGoAway(0 /*max id*/, ErrCodeNo, nil); err != nil {
t.Errorf("server1 failed writing GOAWAY: %v", err)
return
Expand All @@ -3833,7 +3834,7 @@ func TestTransportRetryAfterGOAWAY(t *testing.T) {
t.Errorf("server2 failed reading HEADERS: %v", err)
return
}
t.Logf("server2 got %v", hf)
t.Logf("server2 got %v from %v", hf, ct.sc.RemoteAddr())

var buf bytes.Buffer
enc := hpack.NewEncoder(&buf)
Expand Down
0