stdlib/time: add simple tests

go-python · sbinet · Mar 24, 2022 · Mar 23, 2022 · Mar 23, 2022 · Mar 24, 2022
commit 51a6831b9041ec7105912a574548eb60ea22a1fd
diff --git a/stdlib/time/testdata/test.py b/stdlib/time/testdata/test.py
@@ -0,0 +1,49 @@
+# Copyright 2022 The go-python Authors.  All rights reserved.
+# Use of this source code is governed by a BSD-style
+# license that can be found in the LICENSE file.
+
+import time
+
+now = time.time()
+now = time.time_ns()
+now = time.clock()
+
+def notimplemented(fn, *args, **kwargs):
+    try:
+        fn(*args, **kwargs)
+        print("error for %s(%s, %s)" % (fn,args,kwargs))
+    except NotImplementedError:
+        pass
+
+notimplemented(time.clock_gettime)
+notimplemented(time.clock_settime)
+
+print("# sleep")
+time.sleep(0.1)
+try:
+    time.sleep(-1)
+    print("no error sleep(-1)")
+except ValueError as e:
+    print("caught error: %s" % (e,))
+    pass
+try:
+    time.sleep("1")
+    print("no error sleep('1')")
+except TypeError as e:
+    print("caught error: %s" % (e,))
+    pass
+
+notimplemented(time.gmtime)
+notimplemented(time.localtime)
+notimplemented(time.asctime)
+notimplemented(time.ctime)
+notimplemented(time.mktime, 1)
+notimplemented(time.strftime)
+notimplemented(time.strptime)
+notimplemented(time.tzset)
+notimplemented(time.monotonic)
+notimplemented(time.process_time)
+notimplemented(time.perf_counter)
+notimplemented(time.get_clock_info)
+
+print("OK")
diff --git a/stdlib/time/testdata/test_golden.txt b/stdlib/time/testdata/test_golden.txt
@@ -0,0 +1,4 @@
+# sleep
+caught error: ValueError: 'sleep length must be non-negative'
+caught error: TypeError: 'sleep() argument 1 must be float, not str'
+OK
diff --git a/stdlib/time/time.go b/stdlib/time/time.go
@@ -150,7 +150,7 @@ func time_sleep(self py.Object, args py.Tuple) (py.Object, error) {
 	if secs < 0 {
 		return nil, py.ExceptionNewf(py.ValueError, "sleep length must be non-negative")
 	}
-	time.Sleep(time.Duration(secs * 1e9))
+	time.Sleep(time.Duration(secs * py.Float(time.Second)))
 	return py.None, nil
 }
 
@@ -1007,17 +1007,15 @@ func init() {
 		py.MustNewMethod("perf_counter", time_perf_counter, 0, perf_counter_doc),
 		py.MustNewMethod("get_clock_info", time_get_clock_info, 0, get_clock_info_doc),
 	}
-	
+
 	py.RegisterModule(&py.ModuleImpl{
 		Info: py.ModuleInfo{
-			Name:  "time",
-			Doc:   module_doc,
+			Name: "time",
+			Doc:  module_doc,
 		},
 		Methods: methods,
-		Globals: py.StringDict{
-		},
+		Globals: py.StringDict{},
 	})
-
 }
 
 const module_doc = `This module provides various functions to manipulate time values.

diff --git a/stdlib/time/time_test.go b/stdlib/time/time_test.go
@@ -0,0 +1,15 @@
+// Copyright 2022 The go-python Authors.  All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package time_test
+
+import (
+	"testing"
+
+	"github.com/go-python/gpython/pytest"
+)
+
+func TestTime(t *testing.T) {
+	pytest.RunScript(t, "./testdata/test.py")
+}