8000 Fix get / delete runner to use consistent http 404 and 500 status (#34480) by GiteaBot · Pull Request #34488 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Fix get / delete runner to use consistent http 404 and 500 status (#34480) #34488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2025
Merged

Fix get / delete runner to use consistent http 404 and 500 status (#34480) 8000 #34488

merged 3 commits into from
May 16, 2025

Conversation

GiteaBot
Copy link
Collaborator

Backport #34480 by @ChristopherHX

  • previously deleting an already deleted runner returned http 500
  • previously any database error for the get endpoint was http 404 and never 500

@ChristopherHX @GiteaBot
Fix get / delete runner to use consistent http 404 and 500 status (go…
59c17ea 
…-gitea#34480)

* previously deleting an already deleted runner returned http 500
* previously any database error for the get endpoint was http 404 and never 500
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 16, 2025
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone May 16, 2025
@GiteaBot GiteaBot requested a review from wxiaoguang May 16, 2025 14:09
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) May 16, 2025 16:09
@techknowlogick techknowlogick added type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 16, 2025
@techknowlogick techknowlogick merged commit 21731c1 into go-gitea:release/v1.24 May 16, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@ChristopherHX ChristopherHX

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @wxiaoguang @ChristopherHX @techknowlogick
0