8000 Add a button editing action secret #34348 by NorthRealm · Pull Request #34462 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Add a button editing action secret #34348 #34462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2025
Merged

Add a button editing action secret #34348 #34462

merged 3 commits into from
May 16, 2025

Conversation

NorthRealm
Copy link
Contributor

Backport #34348

@NorthRealm @wxiaoguang
Add a button editing action secret (go-gitea#34348)
97e425c 
Add a button editing action secret
Closes go-gitea#34190

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 4c611bf)
@GiteaBot GiteaBot added this to the 1.24.0 milestone May 14, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 14, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels May 14, 2025
@lunny
Copy link
Member
lunny commented May 15, 2025

Since this is an enhancement, I don't think it's necessary to be backport.

@NorthRealm
Copy link
Contributor Author

em I still think it worthy.

wxiaoguang
wxiaoguang approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, simple enough.

Usually we don't backport locale related changes, but I guess the enhancement is worthy even if we miss some translations.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2025
@GiteaBot GiteaBot a D1C4 dded lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) May 16, 2025 14:43
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2025
@techknowlogick techknowlogick merged commit 47537a8 into go-gitea:release/v1.24 May 16, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2025
@NorthRealm NorthRealm deleted the backport34348 branch May 16, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@NorthRealm @lunny @techknowlogick @wxiaoguang @GiteaBot
0