8000 Fix remove org user failure on mssql by ChristopherHX · Pull Request #34449 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Fix remove org user failure on mssql #34449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

Fix remove org user failure on mssql #34449

merged 2 commits into from
May 13, 2025

Conversation

ChristopherHX
Copy link
Contributor
@ChristopherHX ChristopherHX commented May 13, 2025 •
edited
Loading
  • mssql does not support fetching 0 repositories
    • remove paging by NumRepos that might be 0
  • extend admin api test to purge user 2

Fixes #34448

@ChristopherHX
Fix remove org user failure on mssql
3d0644b 
* mssql does not support fetching 0 repositories
* extend admin api test to purge user 2
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 13, 2025
@ChristopherHX ChristopherHX added backport/v1.24 This PR should be backported to Gitea 1.24 modifies/go Pull requests that update Go code and removed modifies/go Pull requests that update Go code labels May 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2025
@ChristopherHX ChristopherHX marked this pull request as ready for review May 13, 2025 16:40
wxiaoguang
wxiaoguang reviewed May 13, 2025
View reviewed changes
wxiaoguang
wxiaoguang approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vote my approval ahead, feel free to improve my changes.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2025
@ChristopherHX
Copy link
Contributor Author

I have nothing to add here and I fully agree with your change, thanks wxiaoguang for the improvements.

@wxiaoguang wxiaoguang merged commit a0595ad into go-gitea:main May 13, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone May 13, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 13, 2025
@ChristopherHX @wxiaoguang @GiteaBot
Fix remove org user failure on mssql (go-gitea#34449)
d64c600 
* mssql does not support fetching 0 repositories
  * remove paging by NumRepos that might be 0
* extend admin api test to purge user 2

Fixes go-gitea#34448

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this pull request May 13, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 13, 2025
lunny pushed a commit that referenced this pull request May 13, 2025
@GiteaBot @ChristopherHX @wxiaoguang
Fix remove org user failure on mssql (#34449) (#34453)
a1dc3c9 
Backport #34449 by @ChristopherHX

* mssql does not support fetching 0 repositories
* remove paging by NumRepos that might be 0
* extend admin api test to purge user 2

Fixes #34448

Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9347855 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add endpoint deleting workflow run (go-gitea#34337)
  Fix remove org user failure on mssql (go-gitea#34449)
  Fix repo broken check (go-gitea#34444)
  Fix comment textarea scroll issue in Firefox (go-gitea#34438)
  Fix releases sidebar navigation link (go-gitea#34436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Deleting a User that belongs to an org with 0 repositories may result in database error in mssql
4 participants
@ChristopherHX @lunny @wxiaoguang @GiteaBot
0