8000 Fix ephemeral runner deletion by ChristopherHX · Pull Request #34447 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

< 8000 bdi class="js-issue-title markdown-title">Fix ephemeral runner deletion #34447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 20, 2025
Merged

Fix ephemeral runner deletion #34447

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b3b8eb5
Fix ephemeral runner deletion
ChristopherHX May 13, 2025
3adc64b
fix fmt
ChristopherHX May 13, 2025
4dcdf9f
fix typo
ChristopherHX May 13, 2025
d593f36
remove length checks of some runner tests
ChristopherHX May 13, 2025
eae6ad2
Merge branch 'main' of https://github.com/go-gitea/gitea into fix-eph…
ChristopherHX May 13, 2025
8e8c127
revert local storage just to be sure
ChristopherHX May 13, 2025
dc08cc2
Merge branch 'main' of https://github.com/go-gitea/gitea into pr/Chri…
ChristopherHX May 13, 2025
46e8086
Revert "revert local storage just to be sure"
ChristopherHX May 13, 2025
ee1058b
fix comment and method name
ChristopherHX May 14, 2025
d344fed
Revert "Revert "revert local storage just to be sure""
ChristopherHX May 14, 2025
d2af3ea
...
ChristopherHX May 14, 2025
6da57f5
rename test
ChristopherHX May 14, 2025
577a6dd
Merge branch 'main' into fix-ephemeral-runner-deletion
GiteaBot May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments. 8000
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert local storage just to be sure
  • Loading branch information
@ChristopherHX
ChristopherHX committed May 13, 2025
commit 8e8c1277e37ee094d519002196279bd553d60647
6 changes: 1 addition & 5 deletions modules/storage/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (l *LocalStorage) URL(path, name string, reqParams url.Values) (*url.URL, e
// IterateObjects iterates across the objects in the local storage
func (l *LocalStorage) IterateObjects(dirName string, fn func(path string, obj Object) error) error {
dir := l.buildLocalPath(dirName)
err := filepath.WalkDir(dir, func(path string, d os.DirEntry, err error) error {
return filepath.WalkDir(dir, func(path string, d os.DirEntry, err error) error {
if err != nil {
return err
}
Expand All @@ -147,10 +147,6 @@ func (l *LocalStorage) IterateObjects(dirName string, fn func(path string, obj O
defer obj.Close()
return fn(relPath, obj)
})
if os.IsNotExist(err) {
return nil
}
return err
}

func init() {
Expand Down
0