8000 Fix comment textarea scroll issue in Firefox (#34438) by GiteaBot · Pull Request #34446 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Fix comment textarea scroll issue in Firefox (#34438) #34446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Fix comment textarea scroll issue in Firefox (#34438) #34446

merged 1 commit into from
May 13, 2025

Conversation

GiteaBot
Copy link
Collaborator

Backport #34438 by @silverwind

In the comment editor, there is a bug in Firefox where the scroll position unexpectedly moves up, which is annoying. This is not reproducible in Chrome and Safari. To reproduce here are some steps:

  • Go into an editable issue
  • Scroll page to bottom
  • Focus the textarea and press Return many times, causing the textarea to get a scrollbar
  • Scroll page to bottom again
  • Press Return once more
  • Page should not scroll up.

This fixes the bug by adding a temporary margin, and I verified it works in all browsers.

@silverwind @wxiaoguang @GiteaBot
Fix comment textarea scroll issue in Firefox (go-gitea#34438)
58593ff 
In the comment editor, there is a bug in Firefox where the scroll
position unexpectedly moves up, which is annoying. This is not
reproducible in Chrome and Safari. To reproduce here are some steps:

- Go into an editable issue
- Scroll page to bottom
- Focus the textarea and press Return many times, causing the textarea
to get a scrollbar
- Scroll page to bottom again
- Press Return once more
- Page should not scroll up.

This fixes the bug by adding a temporary margin, and I verified it works
in all browsers.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added this to the 1.24.0 milestone May 13, 2025
@GiteaBot 8000 GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2025
@GiteaBot GiteaBot requested review from delvh and wxiaoguang May 13, 2025 06:52
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2025
@silverwind silverwind merged commit 89f1df0 into go-gitea:release/v1.24 May 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @lunny @silverwind
0