Add .diff and .patch support to compare #34433
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some things in my mind:
|
3acbb9f to
bc79694
Compare
wxiaoguang
reviewed
May 14, 2025
| @@ -73,3 +73,14 @@ func (repo *Repository) GetTreePathLatestCommit(refName, treePath string) (*Comm | |||
| } | |||
| return repo.GetCommit(strings.TrimSpace(stdout)) | |||
| } | |||
|
|
|||
| // RevParse resolves a revision reference to other git-related objects | |||
| func (repo *Repository) RevParse(ref, file string) (string, error) { | |||
There was a problem hiding this comment.
Where is it really used except the tests?
There was a problem hiding this comment.
Thanks ill either move it to test files or find a workaround
wxiaoguang
reviewed
May 14, 2025
Comment on lines
+243
to
+244
| ref2IsBranch := gitrepo.IsBranchExist(ctx, ctx.Repo.Repository, infos[1]) | ||
| ref2IsTag := gitrepo.IsTagExist(ctx, ctx.Repo.Repository, infos[1]) |
There was a problem hiding this comment.
The path format is like this:
What if the path is {:baseBranch}...{:headOwner}/{:headRepoName}:{:headBranch}.patch?
There was a problem hiding this comment.
Thanks ill address that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposal #34410
