Use run-name and evaluate workflow variables #34301
Conversation
|
Shouldn't this go to jobparser? |
|
@TheFox0x7 |
cca335d to
9408c76
Compare
|
Hey @lunny you think I can get someone to review https://gitea.com/gitea/act/pulls/137 so we can push this forward? |
That PR merged. |
Thanks @lunny |
|
…order DispatchActionWorkflow to support run-name parsing
9633e1d to
7a52cac
Compare
To support go-gitea/gitea#34301 Reviewed-on: https://gitea.com/gitea/act/pulls/137 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: badhezi <zlilaharon@gmail.com> Co-committed-by: badhezi <zlilaharon@gmail.com>
|
Can this PR please be reviewed? |
| if err != nil { | ||
| log.Error("jobparser.Parse: %v", err) | ||
| continue | ||
| } | ||
|
|
||
| if len(jobs) > 0 && jobs[0].RunName != "" { |
There was a problem hiding this comment.
According to the yaml file, the run-name is the top level key but not belongs to any jobs in that workflow file.
There was a problem hiding this comment.
Hey, yes I agree.
We discussed this briefly before https://gitea.com/gitea/act/pulls/136#issuecomment-1002837
you requested i consolidate the logic into jobparser.Parse()
which actually returns a list of SingleWorkflow, it called "job" because that was the original terminology in the code and i kept that the same.
There is no way for me to return just the interpolated top-level key when need it to exist inside Parse(), which also returns all the individual workflow jobs, so I attach the run name to every workflow (which is not necessarily wrong), and extract just one of them when building the ActionRun / ActionSchedule.
If you would like a different approach I have no problem implementing that.
| log.Error("ToGitHubContext.json.Marshal: %v", err) | ||
| } | ||
|
|
||
| err = json.Unmarshal(gitCtxRaw, ghCtx) |
There was a problem hiding this comment.
It is quite fragile by using Marshal+Unmarshal, it's unclear what value a field would get.
To make it stable, I think we should assign the fields one by one explicitly.
This addresses #34247
depends on https://gitea.com/gitea/act/pulls/137
I couldn't find any previous implementation for
run-namesupport on workflows so I created one.Key points:
All dispatched workflows, scheduled workflows and detected workflows (from different hooks) will use and evaluate
run-nameif exists, with the corresponding gitea context and variables. This will be used as the Action run title and replace the default commit message being used today.Had to change act package jobparser (see link above)
and create two helpers
gitea/models/actions/utils.go
Line 86 in 3a1320c
and
gitea/services/actions/context.go
Line 169 in 3a1320c
to pass the correct types to GenerateGiteaContext and WithGitContext respectively.