8000 actions artifacts api list/download check status upload confirmed by ChristopherHX · Pull Request #34273 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

actions artifacts api list/download check status upload confirmed #34273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025
Merged

actions artifacts api list/download check status upload confirmed #34273

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7668923
actions artifacts internal api list/download check status upload conf…
ChristopherHX Apr 23, 2025
fc1e675
remove duplicate
ChristopherHX Apr 23, 2025
11501c4
code style fixes
ChristopherHX Apr 23, 2025
bf03ae7
more detailed errors
ChristopherHX Apr 24, 2025
c36c31b
Merge branch 'main' into internal-actions-artifacts-api-download-chec…
GiteaBot Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove duplicate
  • Loading branch information
@ChristopherHX
ChristopherHX committed Apr 23, 2025
commit fc1e675862d1acc7c2589553a85f44ad77ccee1b
9 changes: 0 additions & 9 deletions tests/integration/api_actions_artifact_v4_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,17 +565,8 @@
WorkflowJobRunBackendId: "193",
})).
AddTokenAuth(token)
resp = MakeRequest(t, req, http.StatusNotFound)

Check failure on line 568 in tests/integration/api_actions_artifact_v4_test.go

View workflow job for this annotation

GitHub Actions / lint-backend 

assigned to resp, but reassigned without using the value (wastedassign)

Check failure on line 568 in tests/integration/api_actions_artifact_v4_test.go

View workflow job for this annotation

GitHub Actions / lint-go-windows 

assigned to resp, but reassigned without using the value (wastedassign)

Check failure on line 568 in tests/integration/api_actions_artifact_v4_test.go

View workflow job for this annotation

GitHub Actions / lint-go-gogit 

assigned to resp, but reassigned without using the value (wastedassign)

// confirm artifact is no longer accessible by GetSignedArtifactURL
req = NewRequestWithBody(t, "POST", "/twirp/github.actions.results.api.v1.ArtifactService/GetSignedArtifactURL", toProtoJSON(&actions.GetSignedArtifactURLRequest{
Name: "artifact-v4-download",
WorkflowRunBackendId: "792",
WorkflowJobRunBackendId: "193",
})).
AddTokenAuth(token)
resp = MakeRequest(t, req, http.StatusNotFound)

// confirm artifact is no longer enumerateable by ListArtifacts and returns length == 0 without error
req = NewRequestWithBody(t, "POST", "/twirp/github.actions.results.api.v1.ArtifactService/ListArtifacts", toProtoJSON(&actions.ListArtifactsRequest{
NameFilter: wrapperspb.String("artifact-v4-download"),
Expand All @@ -585,7 +576,7 @@
resp = MakeRequest(t, req, http.StatusOK)
var listResp actions.ListArtifactsResponse
protojson.Unmarshal(resp.Body.Bytes(), &listResp)
assert.Len(t, listResp.Artifacts, 0)

Check failure on line 579 in tests/integration/api_actions_artifact_v4_test.go

View workflow job for this annotation

GitHub Actions / lint-backend 

empty: use assert.Empty (testifylint)

Check failure on line 579 in tests/integration/api_actions_artifact_v4_test.go

View workflow job for this annotation

GitHub Actions / lint-go-windows 

empty: use assert.Empty (testifylint)

Check failure on line 579 in tests/integration/api_actions_artifact_v4_test.go

View workflow job for this annotation

GitHub Actions / lint-go-gogit 

empty: use assert.Empty (testifylint)
}

func TestActionsArtifactV4DeletePublicApi(t *testing.T) {
Expand Down
Loading
0