8000 Add workflow_job webhook by ChristopherHX · Pull Request #33694 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Add workflow_job webhook #33694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 11, 2025
Merged

Add workflow_job webhook #33694

merged 25 commits into from
Mar 11, 2025

Conversation

ChristopherHX
Copy link
Contributor

Provide external Integration information about the Queue lossly based on https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=completed#workflow_job

Naming conflicts between GitHub & Gitea are here, Blocked => Waiting, Waiting => Queued

Rationale Enhancement for ephemeral runners management #33570

@ChristopherHX
WIP workflow_job webhook
a4f32e5 
fixup

initial working draft

Add more fields

More Complete
@ChristopherHX
fmt
271ad9f
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2025
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Feb 23, 2025
@ChristopherHX
Copy link
Contributor Author
ChristopherHX commented Feb 23, 2025 •
edited
Loading

BTW, I might need help write tests these for webhooks. This can get complex for me.

Example Webhooks (two jobs, one depends on the other) 
{
  "action": "queued",
  "workflow_job": {
    "id": 344,
    "run_id": 825,
    "run_url": "http://localhost:3000/test/private-repo/actions/runs/10",
    "name": "download",
    "labels": [
      "ephemeral"
    ],
    "run_attempt": 2,
    "head_sha": "a33e70fae58cce6ddf3a3e4c33e7be4fe5ea1533",
    "head_branch": "ephemeral",
    "runner_id": 0,
    "runner_name": "",
    "steps": null,
    "created_at": "2025-02-23T14:51:50Z",
    "started_at": "1970-01-01T00:00:00Z",
    "completed_at": "1970-01-01T00:00:00Z"
  },
  "repository": {
    "id": 65,
    "owner": {
      "id": 43,
      "login": "test",
      "login_name": "",
      "source_id": 0,
      "full_name": "",
      "email": "test@test.com",
      "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
      "html_url": "http://localhost:3000/test",
      "language": "",
      "is_admin": false,
      "last_login": "0001-01-01T00:00:00Z",
      "created": "2025-02-10T13:25:00+01:00",
      "restricted": false,
      "active": false,
      "prohibit_login": false,
      "location": "",
      "website": "",
      "description": "",
      "visibility": "public",
      "followers_count": 0,
      "following_count": 0,
      "starred_repos_count": 0,
      "username": "test"
    },
    "name": "private-repo",
    "full_name": "test/private-repo",
    "description": "",
    "empty": false,
    "private": true,
    "fork": false,
    "template": false,
    "parent": null,
    "mirror": false,
    "size": 33,
    "language": "",
    "languages_url": "http://localhost:3000/api/v1/repos/test/private-repo/languages",
    "html_url": "http://localhost:3000/test/private-repo",
    "url": "http://localhost:3000/api/v1/repos/test/private-repo",
    "link": "",
    "ssh_url": "christopher@localhost:test/private-repo.git",
    "clone_url": "http://localhost:3000/test/private-repo.git",
    "original_url": "",
    "website": "",
    "stars_count": 0,
    "forks_count": 0,
    "watchers_count": 1,
    "open_issues_count": 0,
    "open_pr_counter": 0,
    "release_counter": 0,
    "default_branch": "main",
    "archived": false,
    "created_at": "2025-02-10T20:40:44+01:00",
    "updated_at": "2025-02-23T19:37:50+01:00",
    "archived_at": "1970-01-01T01:00:00+01:00",
    "permissions": {
      "admin": true,
      "push": true,
      "pull": true
    },
    "has_issues": true,
    "internal_tracker": {
      "enable_time_tracker": true,
      "allow_only_contributors_to_track_time": true,
      "enable_issue_dependencies": true
    },
    "has_wiki": true,
    "has_pull_requests": true,
    "has_projects": true,
    "projects_mode": "all",
    "has_releases": true,
    "has_packages": true,
    "has_actions": true,
    "ignore_whitespace_conflicts": false,
    "allow_merge_commits": true,
    "allow_rebase": true,
    "allow_rebase_explicit": true,
    "allow_squash_merge": true,
    "allow_fast_forward_only_merge": true,
    "allow_rebase_update": true,
    "default_delete_branch_after_merge": false,
    "default_merge_style": "merge",
    "default_allow_maintainer_edit": false,
    "avatar_url": "",
    "internal": false,
    "mirror_interval": "",
    "object_format_name": "sha1",
    "mirror_updated": "0001-01-01T00:00:00Z",
    "repo_transfer": null,
    "topics": [],
    "licenses": null
  },
  "sender": {
    "id": 43,
    "login": "test",
    "login_name": "",
    "source_id": 0,
    "full_name": "",
    "email": "test@noreply.localhost",
    "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
    "html_url": "http://localhost:3000/test",
    "language": "",
    "is_admin": false,
    "last_login": "0001-01-01T00:00:00Z",
    "created": "2025-02-10T13:25:00+01:00",
    "restricted": false,
    "active": false,
    "prohibit_login": false,
    "location": "",
    "website": "",
    "description": "",
    "visibility": "public",
    "followers_count": 0,
    "following_count": 0,
    "starred_repos_count": 0,
    "username": "test"
  }
}
{
  "action": "completed",
  "workflow_job": {
    "id": 343,
    "run_id": 825,
    "run_url": "http://localhost:3000/test/private-repo/actions/runs/10",
    "name": "_",
    "labels": [
      "ephemeral"
    ],
    "run_attempt": 3,
    "head_sha": "a33e70fae58cce6ddf3a3e4c33e7be4fe5ea1533",
    "head_branch": "ephemeral",
    "conclusion": "success",
    "runner_id": 194,
    "runner_name": "",
    "steps": [
      {
        "name": "christopherhx/gitea-upload-artifact@v4",
        "number": 0,
        "conclusion": "success",
        "started_at": "2025-02-23T18:37:48Z",
        "completed_at": "2025-02-23T18:37:49Z"
      }
    ],
    "created_at": "2025-02-23T14:51:50Z",
    "started_at": "2025-02-23T18:37:48Z",
    "completed_at": "2025-02-23T18:37:49Z"
  },
  "repository": {
    "id": 65,
    "owner": {
      "id": 43,
      "login": "test",
      "login_name": "",
      "source_id": 0,
      "full_name": "",
      "email": "test@test.com",
      "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
      "html_url": "http://localhost:3000/test",
      "language": "",
      "is_admin": false,
      "last_login": "0001-01-01T00:00:00Z",
      "created": "2025-02-10T13:25:00+01:00",
      "restricted": false,
      "active": false,
      "prohibit_login": false,
      "location": "",
      "website": "",
      "description": "",
      "visibility": "public",
      "followers_count": 0,
      "following_count": 0,
      "starred_repos_count": 0,
      "username": "test"
    },
    "name": "private-repo",
    "full_name": "test/private-repo",
    "description": "",
    "empty": false,
    "private": true,
    "fork": false,
    "template": false,
    "parent": null,
    "mirror": false,
    "size": 33,
    "language": "",
    "languages_url": "http://localhost:3000/api/v1/repos/test/private-repo/languages",
    "html_url": "http://localhost:3000/test/private-repo",
    "url": "http://localhost:3000/api/v1/repos/test/private-repo",
    "link": "",
    "ssh_url": "christopher@localhost:test/private-repo.git",
    "clone_url": "http://localhost:3000/test/private-repo.git",
    "original_url": "",
    "website": "",
    "stars_count": 0,
    "forks_count": 0,
    "watchers_count": 1,
    "open_issues_count": 0,
    "open_pr_counter": 0,
    "release_counter": 0,
    "default_branch": "main",
    "archived": false,
    "created_at": "2025-02-10T20:40:44+01:00",
    "updated_at": "2025-02-23T19:37:49+01:00",
    "archived_at": "1970-01-01T01:00:00+01:00",
    "permissions": {
      "admin": true,
      "push": true,
      "pull": true
    },
    "has_issues": true,
    "internal_tracker": {
      "enable_time_tracker": true,
      "allow_only_contributors_to_track_time": true,
      "enable_issue_dependencies": true
    },
    "has_wiki": true,
    "has_pull_requests": true,
    "has_projects": true,
    "projects_mode": "all",
    "has_releases": true,
    "has_packages": true,
    "has_actions": true,
    "ignore_whitespace_conflicts": false,
    "allow_merge_commits": true,
    "allow_rebase": true,
    "allow_rebase_explicit": true,
    "allow_squash_merge": true,
    "allow_fast_forward_only_merge": true,
    "allow_rebase_update": true,
    "default_delete_branch_after_merge": false,
    "default_merge_style": "merge",
    "default_allow_maintainer_edit": false,
    "avatar_url": "",
    "internal": false,
    "mirror_interval": "",
    "object_format_name": "sha1",
    "mirror_updated": "0001-01-01T00:00:00Z",
    "repo_transfer": null,
    "topics": [],
    "licenses": null
  },
  "sender": {
    "id": 43,
    "login": "test",
    "login_name": "",
    "source_id": 0,
    "full_name": "",
    "email": "test@noreply.localhost",
    "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
    "html_url": "http://localhost:3000/test",
    "language": "",
    "is_admin": false,
    "last_login": "0001-01-01T00:00:00Z",
    "created": "2025-02-10T13:25:00+01:00",
    "restricted": false,
    "active": false,
    "prohibit_login": false,
    "location": "",
    "website": "",
    "description": "",
    "visibility": "public",
    "followers_count": 0,
    "following_count": 0,
    "starred_repos_count": 0,
    "username": "test"
  }
}
{
  "action": "in_progress",
  "workflow_job": {
    "id": 343,
    "run_id": 825,
    "run_url": "http://localhost:3000/test/private-repo/actions/runs/10",
    "name": "_",
    "labels": [
      "ephemeral"
    ],
    "run_attempt": 3,
    "head_sha": "a33e70fae58cce6ddf3a3e4c33e7be4fe5ea1533",
    "head_branch": "ephemeral",
    "runner_id": 194,
    "runner_name": "",
    "steps": [
      {
        "name": "christopherhx/gitea-upload-artifact@v4",
        "number": 0,
        "started_at": "1970-01-01T00:00:00Z",
        "completed_at": "1970-01-01T00:00:00Z"
      }
    ],
    "created_at": "2025-02-23T14:51:50Z",
    "started_at": "2025-02-23T18:37:48Z",
    "completed_at": "1970-01-01T00:00:00Z"
  },
  "repository": {
    "id": 65,
    "owner": {
      "id": 43,
      "login": "test",
      "login_name": "",
      "source_id": 0,
      "full_name": "",
      "email": "test@test.com",
      "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
      "html_url": "http://localhost:3000/test",
      "language": "",
      "is_admin": false,
      "last_login": "0001-01-01T00:00:00Z",
      "created": "2025-02-10T13:25:00+01:00",
      "restricted": false,
      "active": false,
      "prohibit_login": false,
      "location": "",
      "website": "",
      "description": "",
      "visibility": "public",
      "followers_count": 0,
      "following_count": 0,
      "starred_repos_count": 0,
      "username": "test"
    },
    "name": "private-repo",
    "full_name": "test/private-repo",
    "description": "",
    "empty": false,
    "private": true,
    "fork": false,
    "template": false,
    "parent": null,
    "mirror": false,
    "size": 33,
    "language": "",
    "languages_url": "http://localhost:3000/api/v1/repos/test/private-repo/languages",
    "html_url": "http://localhost:3000/test/private-repo",
    "url": "http://localhost:3000/api/v1/repos/test/private-repo",
    "link": "",
    "ssh_url": "christopher@localhost:test/private-repo.git",
    "clone_url": "http://localhost:3000/test/private-repo.git",
    "original_url": "",
    "website": "",
    "stars_count": 0,
    "forks_count": 0,
    "watchers_count": 1,
    "open_issues_count": 0,
    "open_pr_counter": 0,
    "release_counter": 0,
    "default_branch": "main",
    "archived": false,
    "created_at": "2025-02-10T20:40:44+01:00",
    "updated_at": "2025-02-23T19:37:46+01:00",
    "archived_at": "1970-01-01T01:00:00+01:00",
    "permissions": {
      "admin": true,
      "push": true,
      "pull": true
    },
    "has_issues": true,
    "internal_tracker": {
      "enable_time_tracker": true,
      "allow_only_contributors_to_track_time": true,
      "enable_issue_dependencies": true
    },
    "has_wiki": true,
    "has_pull_requests": true,
    "has_projects": true,
    "projects_mode": "all",
    "has_releases": true,
    "has_packages": true,
    "has_actions": true,
    "ignore_whitespace_conflicts": false,
    "allow_merge_commits": true,
    "allow_rebase": true,
    "allow_rebase_explicit": true,
    "allow_squash_merge": true,
    "allow_fast_forward_only_merge": true,
    "allow_rebase_update": true,
    "default_delete_branch_after_merge": false,
    "default_merge_style": "merge",
    "default_allow_maintainer_edit": false,
    "avatar_url": "",
    "internal": false,
    "mirror_interval": "",
    "object_format_name": "sha1",
    "mirror_updated": "0001-01-01T00:00:00Z",
    "repo_transfer": null,
    "topics": [],
    "licenses": null
  },
  "sender": {
    "id": 43,
    "login": "test",
    "login_name": "",
    "source_id": 0,
    "full_name": "",
    "email": "test@noreply.localhost",
    "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
    "html_url": "http://localhost:3000/test",
    "language": "",
    "is_admin": false,
    "last_login": "0001-01-01T00:00:00Z",
    "created": "2025-02-10T13:25:00+01:00",
    "restricted": false,
    "active": false,
    "prohibit_login": false,
    "location": "",
    "website": "",
    "description": "",
    "visibility": "public",
    "followers_count": 0,
    "following_count": 0,
    "starred_repos_count": 0,
    "username": "test"
  }
}
{
  "action": "waiting",
  "workflow_job": {
    "id": 344,
    "run_id": 825,
    "run_url": "http://localhost:3000/test/private-repo/actions/runs/10",
    "name": "download",
    "labels": [
      "ephemeral"
    ],
    "run_attempt": 2,
    "head_sha": "a33e70fae58cce6ddf3a3e4c33e7be4fe5ea1533",
    "head_branch": "ephemeral",
    "runner_id": 0,
    "runner_name": "",
    "steps": null,
    "created_at": "2025-02-23T14:51:50Z",
    "started_at": "1970-01-01T00:00:00Z",
    "completed_at": "1970-01-01T00:00:00Z"
  },
  "repository": {
    "id": 65,
    "owner": {
      "id": 43,
      "login": "test",
      "login_name": "",
      "source_id": 0,
      "full_name": "",
      "email": "test@test.com",
      "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
      "html_url": "http://localhost:3000/test",
      "language": "",
      "is_admin": false,
      "last_login": "0001-01-01T00:00:00Z",
      "created": "2025-02-10T13:25:00+01:00",
      "restricted": false,
      "active": false,
      "prohibit_login": false,
      "location": "",
      "website": "",
      "description": "",
      "visibility": "public",
      "followers_count": 0,
      "following_count": 0,
      "starred_repos_count": 0,
      "username": "test"
    },
    "name": "private-repo",
    "full_name": "test/private-repo",
    "description": "",
    "empty": false,
    "private": true,
    "fork": false,
    "template": false,
    "parent": null,
    "mirror": false,
    "size": 33,
    "language": "",
    "languages_url": "http://localhost:3000/api/v1/repos/test/private-repo/languages",
    "html_url": "http://localhost:3000/test/private-repo",
    "url": "http://localhost:3000/api/v1/repos/test/private-repo",
    "link": "",
    "ssh_url": "christopher@localhost:test/private-repo.git",
    "clone_url": "http://localhost:3000/test/private-repo.git",
    "original_url": "",
    "website": "",
    "stars_count": 0,
    "forks_count": 0,
    "watchers_count": 1,
    "open_issues_count": 0,
    "open_pr_counter": 0,
    "release_counter": 0,
    "default_branch": "main",
    "archived": false,
    "created_at": "2025-02-10T20:40:44+01:00",
    "updated_at": "2025-02-23T16:38:21+01:00",
    "archived_at": "1970-01-01T01:00:00+01:00",
    "permissions": {
      "admin": true,
      "push": true,
      "pull": true
    },
    "has_issues": true,
    "internal_tracker": {
      "enable_time_tracker": true,
      "allow_only_contributors_to_track_time": true,
      "enable_issue_dependencies": true
    },
    "has_wiki": true,
    "has_pull_requests": true,
    "has_projects": true,
    "projects_mode": "all",
    "has_releases": true,
    "has_packages": true,
    "has_actions": true,
    "ignore_whitespace_conflicts": false,
    "allow_merge_commits": true,
    "allow_rebase": true,
    "allow_rebase_explicit": true,
    "allow_squash_merge": true,
    "allow_fast_forward_only_merge": true,
    "allow_rebase_update": true,
    "default_delete_branch_after_merge": false,
    "default_merge_style": "merge",
    "default_allow_maintainer_edit": false,
    "avatar_url": "",
    "internal": false,
    "mirror_interval": "",
    "object_format_name": "sha1",
    "mirror_updated": "0001-01-01T00:00:00Z",
    "repo_transfer": null,
    "topics": [],
    "licenses": null
  },
  "sender": {
    "id": 43,
    "login": "test",
    "login_name": "",
    "source_id": 0,
    "full_name": "",
    "email": "test@noreply.localhost",
    "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
    "html_url": "http://localhost:3000/test",
    "language": "",
    "is_admin": false,
    "last_login": "0001-01-01T00:00:00Z",
    "created": "2025-02-10T13:25:00+01:00",
    "restricted": false,
    "active": false,
    "prohibit_login": false,
    "location": "",
    "website": "",
    "description": "",
    "visibility": "public",
    "followers_count": 0,
    "following_count": 0,
    "starred_repos_count": 0,
    "username": "test"
  }
}
{
  "action": "queued",
  "workflow_job": {
    "id": 343,
    "run_id": 825,
    "run_url": "http://localhost:3000/test/private-repo/actions/runs/10",
    "name": "_",
    "labels": [
      "ephemeral"
    ],
    "run_attempt": 2,
    "head_sha": "a33e70fae58cce6ddf3a3e4c33e7be4fe5ea1533",
    "head_branch": "ephemeral",
    "runner_id": 0,
    "runner_name": "",
    "steps": null,
    "created_at": "2025-02-23T14:51:50Z",
    "started_at": "1970-01-01T00:00:00Z",
    "completed_at": "1970-01-01T00:00:00Z"
  },
  "repository": {
    "id": 65,
    "owner": {
      "id": 43,
      "login": "test",
      "login_name": "",
      "source_id": 0,
      "full_name": "",
      "email": "test@test.com",
      "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
      "html_url": "http://localhost:3000/test",
      "language": "",
      "is_admin": false,
      "last_login": "0001-01-01T00:00:00Z",
      "created": "2025-02-10T13:25:00+01:00",
      "restricted": false,
      "active": false,
      "prohibit_login": false,
      "location": "",
      "website": "",
      "description": "",
      "visibility": "public",
      "followers_count": 0,
      "following_count": 0,
      "starred_repos_count": 0,
      "username": "test"
    },
    "name": "private-repo",
    "full_name": "test/private-repo",
    "description": "",
    "empty": false,
    "private": true,
    "fork": false,
    "template": false,
    "parent": null,
    "mirror": false,
    "size": 33,
    "language": "",
    "languages_url": "http://localhost:3000/api/v1/repos/test/private-repo/languages",
    "html_url": "http://localhost:3000/test/private-repo",
    "url": "http://localhost:3000/api/v1/repos/test/private-repo",
    "link": "",
    "ssh_url": "christopher@localhost:test/private-repo.git",
    "clone_url": "http://localhost:3000/test/private-repo.git",
    "original_url": "",
    "website": "",
    "stars_count": 0,
    "forks_count": 0,
    "watchers_count": 1,
    "open_issues_count": 0,
    "open_pr_counter": 0,
    "release_counter": 0,
    "default_branch": "main",
    "archived": false,
    "created_at": "2025-02-10T20:40:44+01:00",
    "updated_at": "2025-02-23T16:38:21+01:00",
    "archived_at": "1970-01-01T01:00:00+01:00",
    "permissions": {
      "admin": true,
      "push": true,
      "pull": true
    },
    "has_issues": true,
    "internal_tracker": {
      "enable_time_tracker": true,
      "allow_only_contributors_to_track_time": true,
      "enable_issue_dependencies": true
    },
    "has_wiki": true,
    "has_pull_requests": true,
    "has_projects": true,
    "projects_mode": "all",
    "has_releases": true,
    "has_packages": true,
    "has_actions": true,
    "ignore_whitespace_conflicts": false,
    "allow_merge_commits": true,
    "allow_rebase": true,
    "allow_rebase_explicit": true,
    "allow_squash_merge": true,
    "allow_fast_forward_only_merge": true,
    "allow_rebase_update": true,
    "default_delete_branch_after_merge": false,
    "default_merge_style": "merge",
    "default_allow_maintainer_edit": false,
    "avatar_url": "",
    "internal": false,
    "mirror_interval": "",
    "object_format_name": "sha1",
    "mirror_updated": "0001-01-01T00:00:00Z",
    "repo_transfer": null,
    "topics": [],
    "licenses": null
  },
  "sender": {
    "id": 43,
    "login": "test",
    "login_name": "",
    "source_id": 0,
    "full_name": "",
    "email": "test@noreply.localhost",
    "avatar_url": "http://localhost:3000/avatars/b642b4217b34b1e8d3bd915fc65c4452",
    "html_url": "http://localhost:3000/test",
    "language": "",
    "is_admin": false,
    "last_login": "0001-01-01T00:00:00Z",
    "created": "2025-02-10T13:25:00+01:00",
    "restricted": false,
    "active": false,
    "prohibit_login": false,
    "location": "",
    "website": "",
    "description": "",
    "visibility": "public",
    "followers_count": 0,
    "following_count": 0,
    "starred_repos_count": 0,
    "username": "test"
  }
}

@ChristopherHX ChristopherHX mentioned this pull request Feb 23, 2025
Closed
6 tasks
@lunny lunny added this to the 1.24.0 milestone Feb 24, 2025
@lunny
Copy link
Member
lunny commented Feb 24, 2025

There are some examples in repo_webhook_test.go.

lunny
lunny reviewed Feb 24, 2025
View reviewed changes
lunny
lunny reviewed Feb 24, 2025
View reviewed changes
@ChristopherHX
Rename notifier to WorkflowJobStatusUpdate
618f044 
* add URL field
* add HTMLURL field
* fix run_url to return api url instead of html url
@ChristopherHX
test more fields
1684975
@ChristopherHX
fix naming of htmlurl
da2180e
@ChristopherHX
Copy link
Contributor Author
ChristopherHX commented Feb 25, 2025 •
edited
Loading

Notice for myself: Possible missing completed event for scenario: CancelPreviousJobs

Hmm, adding code to this method creates an import cycle if I call the webhook not so easy than I expected.

@ChristopherHX ChristopherHX mentioned this pull request Feb 28, 2025
Open
@lunny lunny mentioned this pull request Mar 1, 2025
Open
@ChristopherHX ChristopherHX mentioned this pull request Mar 1, 2025
Closed
lunny
lunny reviewed Mar 3, 2025
View reviewed changes
@ChristopherHX
Copy link
Contributor Author
ChristopherHX commented Mar 5, 2025 •
edited
Loading

Currently discord webhook looks like this

Bildschirmfoto 2025-03-05 um 13 43 24

in_progress seems to mess up formatting, together with job name _

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) March 10, 2025 19:09
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 10, 2025
@ChristopherHX

This comment was marked as outdated.

Sign in to view
@Zettat123
Copy link
Contributor

Info for mergers, please let me update this PR once #33764 is merged.

So this PR should be merged after #33764? Maybe you can convert this PR to draft to avoid accidental merge.

@ChristopherHX ChristopherHX marked this pull request as draft March 10, 2025 19:22
auto-merge was automatically disabled March 10, 2025 19:22

Pull request was converted to draft

@ChristopherHX
Copy link
Contributor Author
ChristopherHX commented Mar 10, 2025 •
edited
Loading

yes this should be done, I made it a draft until I can update this PR by merging main.

The order doesn't matter, but either PR should account the change of the other one to avoid a needless commit

@GiteaBot
Copy link
Collaborator

@ChristopherHX please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 10, 2025
@ChristopherHX ChristopherHX marked this pull request as ready for review March 10, 2025 23:09
@ChristopherHX
Copy link
Contributor Author

Applied bug fix to this PR, so auto concurrency cancellation invokes the workflow_job event as well

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 11, 2025
@lunny lunny merged commit 651ef66 into go-gitea:main Mar 11, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 11, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
62e84f3 
* giteaofficial/main:
  Fix various Fomantic UI and htmx problems (go-gitea#33851)
  Add workflow_job webhook (go-gitea#33694)
  Fix file icon mapping (go-gitea#33855)
  Drop fomantic build (go-gitea#33845)
  Fix auto concurrency cancellation skips commit status updates (go-gitea#33764)
  Fix test code (go-gitea#33829)
  Remove "noscript" tag from html head (go-gitea#33846)
  Fix material icon & diff highlight (go-gitea#33844)
  Fix LFS URL (go-gitea#33840)
  Add material icons for file list (go-gitea#33837)
@ChristopherHX ChristopherHX mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristopherHX @lunny @Zettat123 @GiteaBot @wxiaoguang @techknowlogick
0