8000 Fix code button alignment (#33345) by GiteaBot · Pull Request #33351 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Fix code button alignment (#33345) #33351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix code button alignment (#33345) #33351

merged 1 commit into from
Jan 22, 2025

Conversation

GiteaBot
Copy link
Collaborator

Backport #33345 by @silverwind

Fixes: #33344

Before:
Screenshot 2025-01-22 at 00 40 03

After:
Screenshot 2025-01-22 at 00 39 51

SVGs should not be put into <span> as this messes with the parent flexbox alignment.

BTW the string "Code" is not translated. Maybe for another PR to keep this backportable.

@silverwind @wxiaoguang @GiteaBot
Fix code button alignment (go-gitea#33345)
ccbace7 
Fixes: go-gitea#33344

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/templates This PR modifies the template files topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality labels Jan 22, 2025
@GiteaBot GiteaBot added this to the 1.23.2 milestone Jan 22, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 22, 2025 07:18
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2025
@wxiaoguang wxiaoguang merged commit e08eed9 into go-gitea:release/v1.23 Jan 22, 2025
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@a1012112796 a1012112796 Awaiting requested review from a1012112796

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @wxiaoguang @silverwind
0