Fix a bug in actions artifact test #32672

Zettat123 · 2024-11-29T07:59:42Z

This bug exists in TestActionsArtifactDownload.

gitea/tests/integration/api_actions_artifact_test.go

Lines 123 to 134 in a1f56f8

    
           var listResp listArtifactsResponse 
        
           DecodeJSON(t, resp, &listResp) 
        
           assert.Equal(t, int64(2), listResp.Count) 
        
           // Return list might be in any order. Get one file. 
        
           var artifactIdx int 
        
           for i, artifact := range listResp.Value { 
        
           	if artifact.Name == "artifact-download" { 
        
           		artifactIdx = i 
        
           		break 
        
           	} 
        
           }

We assert that listResp.Count is 2, so artifactIdx could be 0 or 1.

gitea/tests/integration/api_actions_artifact_test.go

Lines 144 to 147 in a1f56f8

    
           var downloadResp downloadArtifactResponse 
        
           DecodeJSON(t, resp, &downloadResp) 
        
           assert.Len(t, downloadResp.Value, 1) 
        
           assert.Equal(t, "artifact-download/abc.txt", downloadResp.Value[artifactIdx].Path)

Then we assert that the length of downloadResp.Value is 1. If artifactIdx is 1 at this point, the assertion on Line 147 will throw an index out of range error.

* giteaofficial/main:
  Split mail sender sub package from mailer service package (go-gitea#32618)
  Fix a bug in actions artifact test (go-gitea#32672)
  Move GetFeeds to service layer (go-gitea#32526)

go-gitea locked as resolved and limited conversation to collaborators Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix a bug in actions artifact test #32672

Fix a bug in actions artifact test #32672

Uh oh!

Uh oh!

Uh oh!

	var listResp listArtifactsResponse
	DecodeJSON(t, resp, &listResp)
	assert.Equal(t, int64(2), listResp.Count)

	// Return list might be in any order. Get one file.
	var artifactIdx int
	for i, artifact := range listResp.Value {
	if artifact.Name == "artifact-download" {
	artifactIdx = i
	break
	}
	}

	var downloadResp downloadArtifactResponse
	DecodeJSON(t, resp, &downloadResp)
	assert.Len(t, downloadResp.Value, 1)
	assert.Equal(t, "artifact-download/abc.txt", downloadResp.Value[artifactIdx].Path)

Uh oh!

Fix a bug in actions artifact test #32672

Fix a bug in actions artifact test #32672

Uh oh!

Conversation

Uh oh!

Uh oh!