8000 Rearrange Clone Panel by BlenderDefender · Pull Request #31142 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Rearrange Clone Panel #31142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 11, 2024
+191 −195
Merged

Rearrange Clone Panel #31142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8181d3a
feat(WIP): Rearrange clone panel
BlenderDefender May 18, 2024
39d3243
Merge branch 'main' into rearrange-clone-panel
techknowlogick Sep 7, 2024
556eb6c
fix lint
techknowlogick Sep 7, 2024
f5499ca
fix lint
techknowlogick Sep 7, 2024
35dc89a
remove incorrect auto-lintfix
techknowlogick Sep 7, 2024
540e58f
force removal of 'autocorrect' changes
techknowlogick Sep 7, 2024
88876cf
convert to tippy
techknowlogick Sep 7, 2024
d53a222
finish tippy styles
techknowlogick Sep 7, 2024
27458e1
finish tippy styles
techknowlogick Sep 7, 2024
9d42bf3
fix lints
techknowlogick Sep 7, 2024
8bd8b2e
syntax issue
techknowlogick Sep 7, 2024
5859943
syntax issue
techknowlogick Sep 7, 2024
594b946
Merge remote-tracking branch 'upstream/main' into rearrange-clone-panel
techknowlogick Sep 12, 2024
6f8ab5d
add sub-template
techknowlogick Sep 12, 2024
dd8c361
Merge branch 'main' into rearrange-clone-panel
wxiaoguang Dec 11, 2024
14b106a
fix
wxiaoguang Dec 11, 2024
d01f7eb
fix lint
wxiaoguang Dec 11, 2024
2102d65
fix test
wxiaoguang Dec 11, 2024
ea6d4a6
Merge branch 'main' into rearrange-clone-panel
wxiaoguang Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@wxiaoguang
wxiaoguang committed Dec 11, 2024
commit 2102d656bd04bd50f8348a59f7df23c46ce91156
12 changes: 4 additions & 8 deletions templates/repo/clone_buttons.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
<!-- there is always at least one button (by context/repo.go) -->
<!-- there is always at least one button (guaranteed by context/repo.go) -->
<div class="ui action small input clone-buttons-combo">
{{if $.CloneButtonShowHTTPS}}
<button class="ui small button repo-clone-https" data-link="{{$.CloneButtonOriginLink.HTTPS}}">
HTTPS
</button>
<button class="ui small button repo-clone-https" data-link="{{$.CloneButtonOriginLink.HTTPS}}">HTTPS</button>
{{end}}
{{if $.CloneButtonShowSSH}}
<button class="ui small button repo-clone-ssh" data-link="{{$.CloneButtonOriginLink.SSH}}">
SSH
</button>
<button class="ui small button repo-clone-ssh" data-link="{{$.CloneButtonOriginLink.SSH}}">SSH</button>
{{end}}
<input size="10" class="repo-clone-url js-clone-url" value="{{$.CloneButtonOriginLink.HTTPS}}" readonly>
<button class="ui small icon button" data-clipboard-target=".repo-clone-url" data-tooltip-content="{{ctx.Locale.Tr "copy_url"}}" aria-label="{{ctx.Locale.Tr "copy_url"}}">
<button class="ui small icon button" data-clipboard-target=".repo-clone-url" data-tooltip-content="{{ctx.Locale.Tr "copy_url"}}">
{{svg "octicon-copy" 14}}
</button>
</div>
2 changes: 1 addition & 1 deletion templates/repo/clone_panel.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<div class="clone-panel-field">
<div class="ui input tiny action">
<input size="30" class="repo-clone-url js-clone-url" value="{{$.CloneButtonOriginLink.HTTPS}}" readonly>
<div class="ui small compact icon button" data-clipboard-target=".js-clone-url" data-tooltip-content="{{ctx.Locale.Tr "copy_url"}}" aria-label="{{ctx.Locale.Tr "copy_url"}}">
<div class="ui small compact icon button" data-clipboard-target=".js-clone-url" data-tooltip-content="{{ctx.Locale.Tr "copy_url"}}">
{{svg "octicon-copy" 14}}
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions tests/integration/repo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ func TestViewRepo1CloneLinkAnonymous(t *testing.T) {
resp := MakeRequest(t, req, http.StatusOK)

htmlDoc := NewHTMLParser(t, resp.Body)
link, exists := htmlDoc.doc.Find("#repo-clone-https").Attr("data-link")
link, exists := htmlDoc.doc.Find(".repo-clone-https").Attr("data-link")
assert.True(t, exists, "The template has changed")
assert.Equal(t, setting.AppURL+"user2/repo1.git", link)
_, exists = htmlDoc.doc.Find("#repo-clone-ssh").Attr("data-link")
_, exists = htmlDoc.doc.Find(".repo-clone-ssh").Attr("data-link")
assert.False(t, exists)
}

Expand All @@ -143,10 +143,10 @@ func TestViewRepo1CloneLinkAuthorized(t *testing.T) {
resp := session.MakeRequest(t, req, http.StatusOK)

htmlDoc := NewHTMLParser(t, resp.Body)
link, exists := htmlDoc.doc.Find("#repo-clone-https").Attr("data-link")
link, exists := htmlDoc.doc.Find(".repo-clone-https").Attr("data-link")
assert.True(t, exists, "The template has changed")
assert.Equal(t, setting.AppURL+"user2/repo1.git", link)
link, exists = htmlDoc.doc.Find("#repo-clone-ssh").Attr("data-link")
link, exists = htmlDoc.doc.Find(".repo-clone-ssh").Attr("data-link")
assert.True(t, exists, "The template has changed")
sshURL := fmt.Sprintf("ssh://%s@%s:%d/user2/repo1.git", setting.SSH.User, setting.SSH.Domain, setting.SSH.Port)
assert.Equal(t, sshURL, link)
Expand Down
Loading
0