10000 Enable poetry cache in `setup-python` by silverwind · Pull Request #30607 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Enable poetry cache in setup-python #30607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enable poetry cache in setup-python #30607

wants to merge 2 commits into from

Conversation

silverwind
Copy link
Member
@silverwind silverwind commented Apr 19, 2024 •
edited
Loading

Same as the go and npm caches, for poetry dependencies. Followed this.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2024
@silverwind
Copy link
Member Author

It seems to only work when poetry is installed before setup-python, so this unfortunately relies on python and pipx being available in the image it runs on.

@silverwind
Copy link
Member Author

I don't like that this depends on python being present before setup-python has ran which apparently also causes issues as seen in actions/setup-python#846, so I will wait until setup-python fixes their stuff.

@silverwind silverwind closed this Apr 19, 2024
@silverwind silverwind deleted the poetrycache branch April 19, 2024 20:23
@silverwind silverwind removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverwind @delvh @GiteaBot
0