8000 Abstract for RepoPath by lunny · Pull Request #28966 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Abstract for RepoPath #28966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Abstract for RepoPath #28966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d573292
Abstract for RepoPath
lunny Jan 28, 2024
e0355cd
More refactoring
lunny Jan 28, 2024
1a1c352
More refactoring
lunny Jan 28, 2024
deeba9c
Some refactoring
lunny Jan 28, 2024
21a14fc
More refactoring
lunny Jan 28, 2024
889147e
Don't use repoPath
lunny Feb 1, 2024
13e252b
Merge branch 'main' into lunny/remove_repo_path
lunny Feb 8, 2024
b7b9892
Merge branch 'main' into lunny/remove_repo_path
lunny Apr 13, 2024
9f49daa
Merge branch 'main' into lunny/remove_repo_path
lunny Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use repoPath
  • Loading branch information
@lunny
lunny committed Feb 1, 2024
commit 889147e96edf2b503e209a4f41cd9ca84aa3451f
2 changes: 1 addition & 1 deletion cmd/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func runRepoSyncReleases(_ *cli.Context) error {
}
log.Trace("Processing next %d repos of %d", len(repos), count)
for _, repo := range repos {
log.Trace("Synchronizing repo %s with path %s", repo.FullName(), repo.RepoPath())
log.Trace("Synchronizing repo %s with path %s", repo.FullName(), gitrepo.RepoGitURL(repo))
gitRepo, err := gitrepo.OpenRepository(ctx, repo)
if err != nil {
log.Warn("OpenRepository: %v", err)
Expand Down
9 changes: 5 additions & 4 deletions models/git/commit_status.go
View file
Open in desktop
579F
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
repo_model "code.gitea.io/gitea/models/repo"
user_model "code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/git"
"code.gitea.io/gitea/modules/gitrepo"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/setting"
api "code.gitea.io/gitea/modules/structs"
Expand Down Expand Up @@ -420,9 +421,9 @@ func NewCommitStatus(ctx context.Context, opts NewCommitStatusOptions) error {
return fmt.Errorf("NewCommitStatus[nil, %s]: no repository specified", opts.SHA)
}

repoPath := opts.Repo.RepoPath()
repoURL := gitrepo.RepoGitURL(opts.Repo)
if opts.Creator == nil {
return fmt.Errorf("NewCommitStatus[%s, %s]: no user specified", repoPath, opts.SHA)
return fmt.Errorf("NewCommitStatus[%s, %s]: no user specified", repoURL, opts.SHA)
}

ctx, committer, err := db.TxContext(ctx)
Expand All @@ -444,13 +445,13 @@ func NewCommitStatus(ctx context.Context, opts NewCommitStatusOptions) error {
opts.CommitStatus.CreatorID = opts.Creator.ID
opts.CommitStatus.RepoID = opts.Repo.ID
opts.CommitStatus.Index = idx
log.Debug("NewCommitStatus[%s, %s]: %d", repoPath, opts.SHA, opts.CommitStatus.Index)
log.Debug("NewCommitStatus[%s, %s]: %d", repoURL, opts.SHA, opts.CommitStatus.Index)

opts.CommitStatus.ContextHash = hashCommitStatusContext(opts.CommitStatus.Context)

// Insert new CommitStatus
if _, err = db.GetEngine(ctx).Insert(opts.CommitStatus); err != nil {
return fmt.Errorf("insert CommitStatus[%s, %s]: %w", repoPath, opts.SHA, err)
return fmt.Errorf("insert CommitStatus[%s, %s]: %w", repoURL, opts.SHA, err)
}

return committer.Commit()
Expand Down
0