status: preloadWithStatus should return the full path, not just file name #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
requested changes
Jun 26, 2025
There was a problem hiding this comment.
@davidrios please add some tests to confirm the expected behaviour.
status.go
Outdated
| continue | ||
| } | ||
| fs := status.File(node.Name()) | ||
| fs := status.File(node.Path) |
There was a problem hiding this comment.
If the only thing we need is the full node path, I believe we could do that with:
Suggested change
| fs := status.File(node.Path) | |
| fs := status.File(node.String()) |
In that case, we could drop the rest of the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1384