10000 SetHostKeyCallback removed in minor version release (v5.15) · Issue #1514 · go-git/go-git · GitHub
[go: up one dir, main page]
Skip to content

SetHostKeyCallback removed in minor version release (v5.15) #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmalloc opened this issue Apr 13, 2025 · 2 comments
Open

SetHostKeyCallback removed in minor version release (v5.15) #1514

jmalloc opened this issue Apr 13, 2025 · 2 comments
Assignees
@pjbgf
Labels
bug Something isn't working

Comments

@jmalloc
Copy link
jmalloc commented Apr 13, 2025

The HostKeyCallbackHelper.SetHostKeyCallback() was removed (or more correctly, replaced with SetHostKeyCallbackAndAlgorithms()?)

See diff: v5.14.0...v5.15.0#diff-512f53c734d78ae512802447f2d46d550e849d296a6102ec8515de90f1fa3563L300

Would it be possible to add a (deprecated) alias with the old name, or restore the old implementation if they are significantly different?

FWIW, I am not using this method in my own codebase, but it is used by Argo CD, which is preventing my project from compiling.

Thanks!
pjbgf added a commit to pjbgf/go-git that referenced this issue Apr 14, 2025
@pjbgf
plumbing: transport, Reintroduce SetHostKeyCallback. Fix go-git#1514
beedd6b 
The PR go-git#1482 renamed SetHostKeyCallback to SetHostKeyCallbackAndAlgorithms, due to
the change in behaviour. For keeping backwards compatibility within existing v5, a
new SetHostKeyCallback is being introduced that simply calls back to
SetHostKeyCallbackAndAlgorithms.

Some tests were introduced to enforce expected behaviour.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@pjbgf pjbgf added the bug Something isn't working label Apr 14, 2025
@pjbgf pjbgf self-assigned this Apr 14, 2025
@pjbgf
Copy link
Member
pjbgf commented Apr 14, 2025

@jmalloc thanks for reporting this. It should be fixed on the proposed PR, we aim to cut a release with a fix in the coming days.

@jmalloc
Copy link
Author
jmalloc commented Apr 14, 2025

Thank you!

pjbgf added a commit that referenced this issue Apr 14, 2025
@pjbgf
Merge pull request #1515 from pjbgf/regre
6d4a5c6 
plumbing: transport, Reintroduce SetHostKeyCallback. Fix #1514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjbgf pjbgf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmalloc @pjbgf
0