delve: support linux-loong64 native debug #2773
Conversation
|
See Delve's porting guide. Also see the build failures. |
|
In general this seems mostly fine. The main two problems are that (a) it doesn't compile on anything but go1.18 and (b) we need to do CI for it. |
delve now can be built (-mod=vendor) to loong64-arch and running on linux-loong64 OS. The following commands work correctly on linux-loong64. 1) running the program: continue, next, restart, step-instruction 2) manipulating breakpoints: break, breakpoints, clear, clearall 3) viewing program variables and memory: regs 4) viewing the call stack and selecting frames: stack, up, down 5) other commands: disassemble(GNU), funcs, list, sources LoongArch documents: https://github.com/loongson/LoongArch-Documentation Patches submitted by related projects for loong64: https://go-review.googlesource.com/c/arch/+/358854 https://go-review.googlesource.com/c/sys/+/355550 https://go-review.googlesource.com/c/go/+/342303 https://github.com/loongson/go (branch: loong64-go1.15.6) https://github.com/creack/pty (already merged) Signed-off-by: Guoqi Chen <chenguoqi@loongson.cn> Co-authored-by: Xiaojuan Zhai <zhaixiaojuan@loongson.cn> Co-authored-by: Meidan Li <limeidan@loongson.cn> CC: Xiaodong Liu <liuxiaodong@loongson.cn>
Thank you！ CI macheine： We can provide machines with loongarch64 instruction architecture that can be accessed remotely. Of course, we can also provide physical machines for CI. What resources do we need to provide to access CI？ Golang compiler： This is go1.15.6 （https://github.com/loongson/go， branch loong64-go1.15.6） that we have transplanted. It can work normally at present。 The patch on go loong64 for master has been submitted to the golang community (see https://go-review.googlesource.com/c/go/ +/342303）。 We are doing our best to merge the patch into the master branch of go as soon as possible. |
Can they run the JVM? These are the instructions for adding an agent: https://www.jetbrains.com/help/teamcity/setting-up-and-running-additional-build-agents.html
I don't think you understand. It is fine if delve needs 1.18 to compile on loong64, because that's the first version of go that supports loong64, but on other architectures it needs to compile all the way down to 1.15, at least. Also the part of the original message where you say "The following commands work correctly on linux-loong64" is slightly concerning. Supporting a few commands isn't a sufficient condition to get merged, it needs to actually pass our test suite (see the porting notes for exceptions). |
It should work as described. Let me know in case of problems. |
|
Any updates on this work? |
delve now can be built (-mod=vendor) to loong64-arch and running on linux-loong64 OS.
The following commands work correctly on linux-loong64.
LoongArch documents:
Patches submitted by related projects for loong64: