Start fixing #525 Windows errors #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10000
Current coverage is 94.87% (diff: 95.34%)@@ master #530 diff @@
==========================================
Files 63 63
Lines 9634 9643 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 9139 9149 +10
+ Misses 495 494 -1
Partials 0 0
|
c6b0a0a to
e6853d5
Compare
+ Do not abspath twice when contructing cloned repo. + Add `git.repo.base` logger.
+ Parse most remote & config-urls \-->/. + Used relative daemon-paths. + Use git-daemon PORT above 10k; on Windows all below need Admin rights. +FIXED git-daemon @with_rw_and_rw_remote_repo(): + test_base.test_with_rw_remote_and_rw_repo() PASS. + test_remote.test_base() now freezes! (so still hidden win_err) + repo_test: minor finally delete test-repos created inside this repo. + util: delete unused `absolute_project_path()`.
+ cmd: use DEVNULL for non PIPEs; no open-file. + TCs: some unitestize-assertions on base & remote TCs.
…d stderr + `handle_process_output()` accepts null-finalizer, to pump completely stderr before raising any errors. + test: Enable `TestGit.test_environment()` on Windows (to checks stderr consumption).
003b02f to
01751aa
Compare
+ Bug discovered after enabling TC in prev commit and rework of fetch. + remote_tc: unitestize assertions. + util: DEL unused `_mktemp()`.
…ions + Ignore `with_extended_output` arg when reaising the exception, keep its behavior when `status==0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--base-pth.+FIXED git-daemon @with_rw_and_rw_remote_repo():
_do_test_fetch()checking function.pump fetch-infos instead of GIL-reading stderr.
cmd.handle_process_output()accepts null-finalizer, to pump completelystderr before raising any errors.
TestGit.test_environment()on Windows (to checks stderrconsumption).
absolute_project_path().git.util.HIDE_WINDOWS_FREEZE_ERRORSflag.