8000 fix: cannot find remote branch by alichherawalla · Pull Request #49 · githubocto/repo-visualizer · GitHub
[go: up one dir, main page]
Skip to content

fix: cannot find remote branch #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

fix: cannot find remote branch #49

merged 1 commit into from
Sep 13, 2022

Conversation

alichherawalla
Copy link
Contributor

Hi,

Thank you for this amazing library! In terms of getting a fingerprint of the project and its structure, there is nothing that I have come across that is easier to use.

While running this action in one of my repos I faced the following issue which this PR resolves

/usr/bin/git rev-parse --verify <branch-name>
fatal: Needed a single revision

and there after pushing fails since it tries to push to a branch that already exists

  /usr/bin/git push --set-upstream origin <branch-name>
  To https://github.com/<org>/<repo-name>
   ! [rejected]        visualizer -> visualizer (non-fast-forward)
  error: failed to push some refs to 'https://github.com/<org>/<repo-name>'
  hint: Updates were rejected because the tip of your current branch is behind
  hint: its remote counterpart. Integrate the remote changes (e.g.
  hint: 'git pull ...') before pushing again.
  hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Changing to git switch with the --track flag solves the problem.

@alichherawalla
Copy link
Contributor Author

This PR addresses and solves this issue

@alichherawalla
Copy link
Contributor Author

@Wattenberger If possible please take a look at this PR

@alichherawalla
Copy link
Contributor Author

possible to please get a review here?

Wattenberger
Wattenberger reviewed Sep 13, 2022
View reviewed changes
index.js
@@ -26275,34 +26275,33 @@ var main = async () => {
const maxDepth = core.getInput("max_depth") || 9;
const customFileColors = JSON.parse(core.getInput("file_colors") || "{}");
const colorEncoding = core.getInput("color_encoding") || "type";
const commitMessage = core.getInput("commit_message") || "Repo visualizer: updated diagram";
const commitMessage = core.getInput("commit_message") || "Repo visualizer: update diagram";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want to make this change in src/index.jsx:30

Wattenberger
Wattenberger suggested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor
@Wattenberger Wattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks for the PR! sorry about the delay, we've been focusing on other projects at the moment. If you want to move the commit message name change to the uncompiled file, I can merge after!

Wattenberger
Wattenberger approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor
@Wattenberger Wattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see! that's from a previous change - we're all good!

@Wattenberger Wattenberger merged commit c2ef914 into githubocto:main Sep 13, 2022
@Wattenberger Wattenberger mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wattenberger Wattenberger Wattenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alichherawalla @Wattenberger
0