8000 feat: duckdb-wasm query UI [DRAFT] by mattrothenberg · Pull Request #39 · githubocto/flat-viewer · GitHub
[go: up one dir, main page]
Skip to content

feat: duckdb-wasm query UI [DRAFT] #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
+1,186 −514
Draft

feat: duckdb-wasm query UI [DRAFT] #39

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fa9d83a
wasm spike successful
May 12, 2022
713488f
auto fetch
May 12, 2022
4127796
wip
May 12, 2022
6f75755
remove janky require shim
May 12, 2022
c225595
remove vite config changes
May 12, 2022
12955b2
error handling
May 12, 2022
8000
e0b17f4
fix stale transaction error
May 12, 2022
abc4d0b
pull in grid component
May 12, 2022
c66c2a2
rudimentary toggle UI
May 12, 2022
54376d9
Update src/components/repo-detail.tsx
mattrothenberg May 16, 2022
c558164
refactor
May 16, 2022
99055d6
remove co-located duckdb package
May 16, 2022
5efc418
use filename as table name
May 16, 2022
c848a11
handle SQL errors
May 16, 2022
7c5a885
move SQL out to query param
May 16, 2022
93c654f
fix: conditionally insert CSV or JSON
May 16, 2022
7fff932
tweaks
May 16, 2022
c83b98c
switch statement for db initialization
May 16, 2022
62bdc9f
suppress fade animation for SQL results
May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: conditionally insert CSV or JSON
  • Loading branch information
Matt Rothenberg committed May 16, 2022
commit 93c654f29334fbddf70c6b2dad0a46b23eed88bd
18 changes: 11 additions & 7 deletions src/components/db-explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import { sql } from "@codemirror/lang-sql";
import {
ErrorBoundary,
ErrorBoundaryProps,
FallbackProps,
} from "react-error-boundary";
import { ErrorBoundary, FallbackProps } from "react-error-boundary";

import { Grid } from "@githubocto/flat-ui";
import CodeMirror from "@uiw/react-codemirror";
Expand Down Expand Up @@ -68,6 +64,7 @@ function DBExplorerInner(props: DBExplorerInnerProps) {
if (!connectionRef.current) return;
const queryRes = await connectionRef.current.query(query);
const asArray = queryRes.toArray();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to convert the result to an array. Arrow tables already behave like arrays of objects if you iterate over them for for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domoritz Fantastic! This felt kludgy and I suspected there was a better way.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map and forEach won't work so you may have to refactor your code a bit but it would be worth it since you avoid a lot of upfront conversion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domoritz Good call. We're ultimately passing this data down to our flat-ui component , so it needs to be in a shape that this component understands (or we need to refactor the component)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to refactor the component. Shouldn't be a big deal, though, and would be great for interoperability anyway.


return {
numRows: queryRes.numRows,
numCols: queryRes.numCols,
Expand Down Expand Up @@ -109,10 +106,17 @@ function DBExplorerInner(props: DBExplorerInnerProps) {

try {
await db.registerFileText(filename, content);
await c.insertCSVFromPath(filename, { name: filenameWithoutExtension });
extension === "csv"
? await c.insertCSVFromPath(filename, {
name: filenameWithoutExtension,
})
: await c.insertJSONFromPath(filename, {
name: filenameWithoutExtension,
});
setDbStatus("success");
setQuery(`select * from '${filenameWithoutExtension}'`);
} catch {
} catch (e) {
console.error(e);
setDbStatus("error");
}
};
Expand Down
0