8000 Addes 'secrets.' prefix to SQL secret example by andmos · Pull Request #6 · githubocto/flat · GitHub
[go: up one dir, main page]

Skip to content

Addes 'secrets.' prefix to SQL secret example #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021

Conversation

andmos
Copy link
Contributor
@andmos andmos commented May 19, 2021

👋
Thanks for this cool project!
When I tested out the project and wanted to use secrets, I got fooled by the placeholder value here, and forgot to add the secrets.* prefix to my variable. Someone used to Github Actions would probably remember this, but it's easy to forget.
You can decide if this is a good contribution or not 😄

@irealva
Copy link
Contributor
irealva commented May 19, 2021

Thanks for pointing this out!

@irealva irealva merged commit 92c99fc into githubocto:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0