8000 Replace grammar for Slim by Jeremy-Walton · Pull Request #7465 · github-linguist/linguist · GitHub
[go: up one dir, main page]
Skip to content

Replace grammar for Slim #7465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

Replace grammar for Slim #7465

merged 1 commit into from
Jul 2, 2025

Conversation

Jeremy-Walton
Copy link
Contributor
@Jeremy-Walton Jeremy-Walton commented Jun 26, 2025 •
edited
Loading

Description

Some ongoing discussion happening in #7460
Basically the current grammar for slim is not handling syntax highlighting properly which makes reviewing PRs in Github harder.

That grammar is no longer actively maintained (see discussion here: hhttps://github.com/slim-template/ruby-slim.tmbundle/issues/55) , but the new one is active.

Checklist:

  • I am changing the source of a syntax highlighting grammar
    • Old: [https://github.com/slim-template/ruby-slim.tmbundle]
    • New: [https://github.com/borama/vscode-ruby-slim]

@Jeremy-Walton Jeremy-Walton requested a review from a team as a code owner June 26, 2025 16:57
@Jeremy-Walton Jeremy-Walton changed the title Replace source for slim with https://github.com/borama/vscode-ruby-slim Replace grammar for slim Jun 26, 2025
@Jeremy-Walton Jeremy-Walton mentioned this pull request Jul 2, 2025
Closed
@lildude lildude changed the title Replace grammar for slim Replace grammar for Slim Jul 2, 2025
lildude
lildude approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member
@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jul 2, 2025
Merged via the queue into github-linguist:main with commit ddd7a2b Jul 2, 2025
5 checks passed
@Jeremy-Walton Jeremy-Walton deleted the jeremy-walton/update-slim-grammar branch July 23, 2025 18:53
@Jeremy-Walton Jeremy-Walton mentioned this pull request Sep 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeremy-Walton @lildude
0