This repository was archived by the owner on Apr 1, 2025. It is now read-only.
semantic-source-0.0.0.1/ghc-8.8.1 #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrix
commented
Oct 3, 2019
| tested-with: | ||
| GHC == 8.6.5 | ||
| GHC == 8.8.1 |
There was a problem hiding this comment.
I’m testing this locally until such time as the rest of the project can use 8.8.1.
| build-depends: | ||
| aeson ^>= 1.4.2.0 | ||
| , base >= 4.12 && < 5 | ||
| , bytestring ^>= 0.10.8.2 | ||
| , deepseq ^>= 1.4.4.0 | ||
| , generic-monoid ^>= 0.1.0.0 | ||
| , hashable ^>= 1.2.7.0 | ||
| , hashable >= 1.2.7 && < 1.4 |
There was a problem hiding this comment.
hashable 1.3 supports ghc 8.8.1, 1.2.x does not. The breaking changes in 1.3 don’t impact us.
aymannadeem
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be appli
312E
ed as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ghc8.8.1 tosemantic-source.