8000 semantic-source-0.0.0.1/ghc-8.8.1 by robrix · Pull Request #307 · github/semantic · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

semantic-source-0.0.0.1/ghc-8.8.1 #307

Merged
merged 8 commits into from
Oct 3, 2019
Merged

Conversation

robrix
Copy link
Contributor
@robrix robrix commented Oct 3, 2019

This PR adds support for ghc 8.8.1 to semantic-source.

tested-with:
GHC == 8.6.5
GHC == 8.8.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m testing this locally until such time as the rest of the project can use 8.8.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-10-03 at 11 38 14 AM

build-depends:
aeson ^>= 1.4.2.0
, base >= 4.12 && < 5
, bytestring ^>= 0.10.8.2
, deepseq ^>= 1.4.4.0
, generic-monoid ^>= 0.1.0.0
, hashable ^>= 1.2.7.0
, hashable >= 1.2.7 && < 1.4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashable 1.3 supports ghc 8.8.1, 1.2.x does not. The breaking changes in 1.3 don’t impact us.

@robrix robrix requested a review from a team October 3, 2019 15:37
@robrix robrix merged commit b9cc776 into master Oct 3, 2019
@robrix robrix deleted the semantic-source-ghc-8.8.1 branch October 3, 2019 15:57
@robrix
Copy link
Contributor Author
robrix commented Oct 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0