8000 Factor source code-related facilities into a new package by robrix · Pull Request #269 · github/semantic · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Factor source code-related facilities into a new package #269

Merged
merged 49 commits into from
Sep 20, 2019
Merged

Factor source code-related facilities into a new package #269

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
974e2ca
Define a semantic-source package.
robrix Sep 20, 2019
a66f459
Merge branch 'master' into semantic-source
robrix Sep 20, 2019
5802d46
Move the ToJSONFields instance for Range into Data.JSON.Fields.
robrix Sep 20, 2019
10e4bbb
Move the ToJSONFields instance for Span into Data.JSON.Fields.
robrix Sep 20, 2019
57ab2f6
Link the doctests against the lib.
robrix Sep 20, 2019
2c99f09
Link the doctests against QuickCheck.
robrix Sep 20, 2019
a126e39
Use the right dir for the doctests.
robrix Sep 20, 2019
4e40108
Copy Range in.
robrix Sep 20, 2019
325e1f1
Derive a Hashable instance for Range.
robrix Sep 20, 2019
ddef713
Copy Span in.
robrix Sep 20, 2019
81f43c9
Move the ToJSONFields instance for Location into Data.JSON.Fields.
robrix Sep 20, 2019
2748529
Copy Location in as Loc.
robrix Sep 20, 2019
cc82051
Depend on semantic-source.
robrix Sep 20, 2019
1d5e150
Switch everything over to using Source.Range.
robrix Sep 20, 2019
17c61c1
Switch everything over to using Source.Span.
robrix Sep 20, 2019
0f8e69c
Switch everything over to using Source.Loc.
robrix Sep 20, 2019
f6e4864
Move the span/range stuff into CMark.
robrix Sep 20, 2019
b20dcf4
Copy Source in.
robrix Sep 20, 2019
8aae312
Rename the Source symbols and recommend importing it qualified.
robrix Sep 20, 2019
ca6a785
Flip lineRangesWithin.
robrix Sep 20, 2019
d929a8c
Make Data.Source reexport Source.Source.
Sep 20, 2019
948deb4
Fixup remaining test cases.
Sep 20, 2019
7b599a6
Use Source.Source instead of Data.Source.
Sep 20, 2019
a422061
Delete Data.Source.
Sep 20, 2019
f17a2e8
Remove Data.Source from the .cabal file.
Sep 20, 2019
f0567fd
De-suffix dropSource and takeSource.
Sep 20, 2019
86682d8
De-suffix sourceBytes.
Sep 20, 2019
74693f4
Bring in the Source tests.
robrix Sep 20, 2019
2ce8b51
:fire: Data.Source.Spec.
robrix Sep 20, 2019
c86186a
:fire: a redundant import.
robrix Sep 20, 2019
a00a78e
Merge branch 'master' into semantic-source
robrix Sep 20, 2019
bb20471
Define lenses for the starts/ends of Range.
robrix Sep 20, 2019
64ef37e
Rename the line/column lenses to line_/column_.
robrix Sep 20, 2019
1e6ebd2
Rename posLine/posColumn to line/column.
robrix Sep 20, 2019
57c385d
Rename the HasSpan start/end lenses to start_/end_.
robrix Sep 20, 2019
d59a44b
Rename the HasSpan span lens to span_.
robrix Sep 20, 2019
7d1567e
:fire: a bunch of redundant hidden imports.
robrix Sep 20, 2019
0312300
Rename the spanStart/spanEnd fields to start/end.
robrix Sep 20, 2019
e08a495
Define a point fiunction for Range.
robrix Sep 20, 2019
935acb4
:memo: point.
robrix Sep 20, 2019
6356443
Define a point constructor for Span.
robrix Sep 20, 2019
e28e81b
:memo: point.
robrix Sep 20, 2019
9551742
Use point to define emptyTerm.
robrix Sep 20, 2019
52bc7e6
Rename locByteRange/locSpan to byteRange/span.
robrix Sep 20, 2019
4bc5491
Extract lens to the top level.
robrix Sep 20, 2019
909fa63
Define a byteRange_ lens for Loc.
robrix Sep 20, 2019
8df1345
Run semantic-source’s tests in CI.
robrix Sep 20, 2019
918bfb4
Apparently this should not exist.
robrix Sep 20, 2019
77ff50b
Run the doctests from the right place.
robrix Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename the HasSpan start/end lenses to start_/end_.
  • Loading branch information
@robrix
robrix committed Sep 20, 2019
commit 57c385d26586197d1f9fb602ed26fec91dbd4489
20 changes: 10 additions & 10 deletions semantic-source/src/Source/Span.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,23 +86,23 @@ column_ = lens column (\p l -> p { column = l })
class HasSpan a where
span :: Lens' a Span

start :: Lens' a Pos
start = span.start
{-# INLINE start #-}
start_ :: Lens' a Pos
start_ = span.start_
{-# INLINE start_ #-}

end :: Lens' a Pos
end = span.end
{-# INLINE end #-}
end_ :: Lens' a Pos
end_ = span.end_
{-# INLINE end_ #-}

instance HasSpan Span where
span = id
{-# INLINE span #-}

start = lens spanStart (\s t -> s { spanStart = t })
{-# INLINE start #-}
start_ = lens spanStart (\s t -> s { spanStart = t })
{-# INLINE start_ #-}

end = lens spanEnd (\s t -> s { spanEnd = t })
{-# INLINE end #-}
end_ = lens spanEnd (\s t -> s { spanEnd = t })
{-# INLINE end_ #-}


type Lens' s a = forall f . Functor f => (a -> f a) -> (s -> f s)
Expand Down
0