8000 Make the library definition flow file strict by koddsson · Pull Request #2 · github/hotkey · GitHub
[go: up one dir, main page]
Skip to content

Make the library definition flow file strict #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2019
Merged

Make the library definition flow file strict #2

merged 1 commit into from
Jan 23, 2019

Conversation

koddsson
Copy link
Contributor

TURNS OUT, I'VE BEEN WRONG ALL ALONG

I thought (and have been suggesting in reviews 😬) that flow files don't need the strict comment because they are strict by default BUT it appears that I'm very wrong. I'm gonna try to blame this on the lack of documentation of .js.flow types but it's pretty much on me, sorry 😭

@koddsson koddsson requested a review from a team January 23, 2019 15:30
@koddsson koddsson merged commit bb607df into master Jan 23, 2019
@koddsson koddsson deleted the make-flow-files-strict branch January 23, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraham dgraham dgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @dgraham
0