Ignore Eclipse .project and .classpath when using build tools Maven or Gradle#3920
Merged
bdougie merged 1 commit intogithub:mainfrom Dec 13, 2021
Merged
Conversation
bd1081f to
7f56496
Compare
|
And for the record, from #3710 (comment), we already have gitignore/Global/Eclipse.gitignore Line 9 in dd9c41b gitignore/Global/Eclipse.gitignore Lines 28 to 29 in dd9c41b pom.xml at least.
|
bdougie
approved these changes
Dec 13, 2021
Contributor
There was a problem hiding this comment.
Thanks for the links and clarification
baincd
added a commit
to baincd/gitignore.io-gitignore
that referenced
this pull request
Dec 19, 2021
These changes have been incorporated directly into the github/gitignore Maven and Gradle templates (github/gitignore#3920), and therefore no longer need to be defined in the patch files as well. This partially reverts #403
lovelypuppy0607
added a commit
to lovelypuppy0607/gitignore-1
that referenced
this pull request
May 11, 2023
…tch (#439) These changes have been incorporated directly into the github/gitignore Maven and Gradle templates (github/gitignore#3920), and therefore no longer need to be defined in the patch files as well. This partially reverts #403
ukushu
pushed a commit
to ukushu/gitignore
that referenced
this pull request
Nov 26, 2025
…tch (#439) These changes have been incorporated directly into the github/gitignore Maven and Gradle templates (github/gitignore#3920), and therefore no longer need to be defined in the patch files as well. This partially reverts #403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Eclipse's documentation confusingly recommends
.classpathand.projectbeing under version control. That recommendation makes sense if neither maven or gradle is used.However, when using either maven or gradle those files are generated each time based on the maven or gradle configuration - which causes issues when those files are version controlled. That is why I recommended ignoring these files only if using maven or gradle, but not for all Eclipse Java projects.
Links to documentation supporting these rule changes:
See #3710 for discussion and additional documentation regarding this change