fixes CodeIgniter.gitignore deleting a critical framework file#3785
Merged
bdougie merged 1 commit intogithub:mainfrom Dec 11, 2021
LoganTann:patch-1
Merged
fixes CodeIgniter.gitignore deleting a critical framework file#3785bdougie merged 1 commit intogithub:mainfrom LoganTann:patch-1
bdougie merged 1 commit intogithub:mainfrom
LoganTann:patch-1
Conversation
After spending a lot of time finding why my app won't run, just noticed that the gitignore I copied introduced a deletion/ignore rule of an internal folder used by the framework. The current gitignore file deletes the folder `/system/Cache/*` and causes the following error when running the App from the CLI or the web server : `Class "CodeIgniter\Cache\CacheFactory" not found `; making the app unable to run. I added the following rule to fix this : `!system/Cache/*`. Note : this won't fix the bug if the system folder is renamed
Contributor
Author
|
(any updates ? this gitignore causes serious problems and need to be updated !) |
Contributor
|
Sorry for the delay. Thanks for the details provided in the OP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain why you’re making a change :
After spending a lot of time finding why my app won't run on a clean install of my repository, I just noticed that the gitignore I copied introduced a deletion/ignore rule of an internal folder used by the framework.
The current gitignore file deletes the folder
/system/Cache/*and causes the following error when running the App from the CLI or the web server :Class "CodeIgniter\Cache\CacheFactory" not found; making the app unable to run.I added the following rule to fix this :
!system/Cache/*.Note : this won't fix the bug if the system folder is renamed