We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
golangci-lint-action
lint
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes: #406
Sorry, something went wrong.
feat: add golangci-lint-action to the lint workflow
3d8d086
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I love the simplicity just need to verify it doesn't this miss a couple of the checks from the existing implementation before merging.
@radar07 thanks for doing this but it loses the go mod checks. Please ensure this still does go mod verify and asserts nothing has changed after go mod tidy.
go mod
go mod verify
go mod tidy
It's ok to lose go fmt because golangci-lint does include that check.
go fmt
@williammartin I missed this totally. I removed the go fmt check and added golangci-lint step after the Run checks.
golangci-lint
chore: revert go mod check
b620cc5
14ed0ce
Merge branch 'main' into add-golangci-lint-action
eb5df3b
2f8c287
williammartin williammartin requested changes
SamMorrowDrums SamMorrowDrums approved these changes
Successfully merging this pull request may close these issues.