fix: enhance Docker publish workflow with additional tagging options #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/docker-publish.yml:79
- The 'type=match' rule does not include a pattern or additional configuration, which may lead to unintended matching behavior. Please review and add the necessary parameters if a specific pattern is intended.
type=match
SamMorrowDrums
previously approved these changes
Apr 8, 2025
|
Thanks for this, I removed the match because it requires a pattern to be provided, but this is a big improvement on the existing tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a significant update to the
docker-publish.ymlworkflow file. The primary change is the addition of multiple tagging rules for Docker images, which enhances the flexibility and control over how images are tagged during the publishing process.Enhancements to Docker image tagging:
.github/workflows/docker-publish.yml: Added various tagging rules including schedule-based, branch-based, tag-based, pull request-based, semantic versioning patterns, SHA, edge, match, and PEP 440. Additionally, a custom rule was added to prevent pre-releases from getting the "latest" tag.Closes #156`