10000 Update pr-checks.yml by aeisenberg · Pull Request #28 · github/gh-codeql · GitHub
[go: up one dir, main page]
Skip to content

Update pr-checks.yml #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update pr-checks.yml #28

merged 2 commits into from
Apr 3, 2024

Conversation

aeisenberg
Copy link
Contributor

No description provided.

@aeisenberg aeisenberg requested a review from a team as a code owner March 22, 2024 21:30
adityasharad
adityasharad previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough review 😁

@aeisenberg
Copy link
Contributor Author

I can't figure this out. My guess is that there's some sort of unprintable char getting returned that is breaking things. But not sure why it's happening on CI only.

It's not really worth spending more time on this, so I think I'll just remove the failing test and getting things through.

@AlexanderBrevig
Copy link
Contributor

I think I found the solution!

head -n 1 closes the pipe, replace with sed '1!d' and it works :)

          LATEST_NIGHTLY_TAG="$(gh api "repos/dsp-testing/codeql-cli-nightlies/releases" --jq ".[] | select(.draft == false) | .tag_name" | sed '1!d')"
          LATEST_NIGHTLY_VERSION="$(gh api "repos/dsp-testing/codeql-cli-nightlies/releases" --jq '.[] | select(.draft == false) | .body '| sed '1!d' | awk '{print $4}')"

@AlexanderBrevig
Copy link
Contributor

I added the fix to #27

@aeisenberg aeisenberg force-pushed the aeisenberg/add-workflow-dispatch branch from a004073 to a700a60 Compare March 25, 2024 14:51
@aeisenberg
Copy link
Contributor Author

Rebasing on #27, which should be running.

@aeisenberg aeisenberg enabled auto-merge March 25, 2024 15:03
@aeisenberg aeisenberg requested a review from adityasharad March 25, 2024 15:03
@aeisenberg aeisenberg merged commit e6a46e8 into main Apr 3, 2024
@angelapwen angelapwen deleted the aeisenberg/add-workflow-dispatch branch April 3, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

@adityasharad adityasharad Awaiting requested review from adityasharad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aeisenberg @AlexanderBrevig @adityasharad @angelapwen
0