8000 Remove mentions of Jekyll 4 & Pygments deprecation from about-github-pages-and-jekyll by janbrasna · Pull Request #31808 · github/docs · GitHub
[go: up one dir, main page]
Skip to content

Remove mentions of Jekyll 4 & Pygments deprecation from about-github-pages-and-jekyll #31808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2024
Merged

Remove mentions of Jekyll 4 & Pygments deprecation from about-github-pages-and-jekyll #31808

merged 3 commits into from
Mar 6, 2024

Conversation

janbrasna
Copy link
Contributor
@janbrasna janbrasna commented Feb 23, 2024 •
edited
Loading

Fixes #30152

about-github-pages-and-jekyll.md#syntax-highlighting

Why:

The reason for deprecation is not correct. The package itself is not deprecated. Mention of Jekyll 4 is extremely confusing as GitHub Pages build using Jekyll 3.9.x …

For reference to commit logs adding the info cross referenced to package release versions see issue:
Closes: #30152

What's being changed (if available, include any code snippets, screenshots, or gifs):

  1. Removing unnecessary info not relevant to the highlighters' use.
  2. Updating highlighter's repo link.
  3. Adding alt highlighter's repo link.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 23, 2024
@janbrasna janbrasna mentioned this pull request Feb 23, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 23, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Feb 23, 2024
@nguyenalex836
Copy link
Contributor
8000

@janbrasna Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added needs SME This proposal needs review from a subject matter expert and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 6, 2024

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@janbrasna Thank you for your patience while our team reviewed! This looks great ✨ I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Mar 6, 2024
Merged via the queue into github:main with commit 85b6105 Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 6, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@janbrasna janbrasna deleted the patch-2 branch March 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert pages Content related to GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pages: misleading description about deprecated code highlighter pygments
2 participants
@janbrasna @nguyenalex836
0