10000 Correct an obvious typo by Arthur-Milchior · Pull Request #13567 · github/docs · GitHub
[go: up one dir, main page]
Skip to content

Correct an obvious typo #13567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2022
Merged

Correct an obvious typo #13567

merged 4 commits into from
Jan 13, 2022

Conversation

Arthur-Milchior
Copy link
Contributor

Why:

Closes #13566

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
welcome bot commented Jan 1, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
10000

@github-actions
Copy link
Contributor
github-actions bot commented Jan 1, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-13567--patch-2 January 1, 2022 03:38 Inactive
AnilSeervi
AnilSeervi reviewed Jan 1, 2022
View reviewed changes
Copy link
Contributor
@AnilSeervi AnilSeervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jekyll won't use Pygments

@Arthur-Milchior @AnilSeervi
Update content/pages/setting-up-a-github-pages-site-with-jekyll/about…
1e6ad04 
…-github-pages-and-jekyll.md

Co-authored-by: Anil Seervi <eurus2000@protonmail.ch>
@Arthur-Milchior
Copy link
Contributor Author

Thanks for the rephrasing and explanation.
The way it was written, I understood that if you indicated "pygments" it will use "rouge" instead of "rouge". Now I understand it means that "it will still uses Rouge instead of the required Pygments". I like your new sentence as it has no more ambiguity

@github-actions github-actions bot temporarily deployed to docs-13567--patch-2 January 1, 2022 21:30 Inactive
@ramyaparimi
Copy link
Contributor

@Arthur-Milchior
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Jan 3, 2022
skedwards88
skedwards88 previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor
@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I made a suggestion to split the addition into two sentences. I'll go ahead an incorporate that change, then get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jan 13, 2022
@skedwards88 skedwards88 enabled auto-merge (squash) January 13, 2022 01:19
@github-actions github-actions bot temporarily deployed to docs-13567--patch-2 January 13, 2022 01:24 Inactive
@skedwards88 skedwards88 merged commit 724a274 into github:main Jan 13, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Arthur-Milchior Arthur-Milchior deleted the patch-2 branch January 13, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnilSeervi AnilSeervi AnilSeervi left review comments

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo in Syntax Highlighting section
4 participants
@Arthur-Milchior @ramyaparimi @skedwards88 @AnilSeervi
0